Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builder pattern for IcebergQueryRunner #24515

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZacBlanco
Copy link
Contributor

@ZacBlanco ZacBlanco commented Feb 7, 2025

Description

Currently we create IcebergQueryRunner through a complicated set of method with various overloads. We tend to just create a new constructor/method for every time we need to set a separate property which can make figuring out
the arguments you're trying to explicitly change for a query runner more difficult to determine.

This change instead introduces a class which uses builder pattern to make the code easier to understand.

Motivation and Context

Simpler and easier to understand query runner.

Impact

N/A. Testing only

Test Plan

Existing tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 7, 2025
@ZacBlanco ZacBlanco force-pushed the upstream-iceberg-qr-builder branch 3 times, most recently from 066bcbe to 4556f18 Compare February 7, 2025 23:21
Additionally, add support for tracking catalog properties
added to iceberg. This can be useful for tests that may
require their own catalogs
@ZacBlanco ZacBlanco force-pushed the upstream-iceberg-qr-builder branch from 4556f18 to 686e6b3 Compare February 8, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants