Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat files in the Iceberg connector #24517

Merged

Conversation

ZacBlanco
Copy link
Contributor

Description

Reformatting to match style guidelines

Motivation and Context

As a part of the project, we have a set of checkstyle guidelines. Generally we recommend developers to use IntelliJ for Java development. If you use the official style guidelines and format with the provided style rules within IntelliJ there are a number of files in the Iceberg connector which don't follow the official formatting rules. Maven checkstyle isn't capable of finding them all automatically.

The changes in this commit are the result of running IntelliJ's reformat procedure on all the files in the Iceberg connector using Presto's officially-provided style rules.

Impact

N/A

Test Plan

N/A

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 7, 2025
As a part of the project, we have a set of checkstyle guidelines.
Generally we recommend developers to use IntelliJ for Java
development. If you use the official style guidelines and format
with the provided style rules within IntelliJ there are a number of
files in the Iceberg connector which don't follow the official
formatting rules. Maven checkstyle isn't capable of finding them
all automatically.

The changes in this commit are the result of running IntelliJ's reformat
procedure on all the files in the Iceberg connector using Presto's
officially-provided style rules.
@ZacBlanco ZacBlanco force-pushed the upstream-iceberg-fix-formatting branch from 8eefeff to d4dd71c Compare February 7, 2025 22:20
@ZacBlanco ZacBlanco marked this pull request as ready for review February 7, 2025 22:26
@ZacBlanco ZacBlanco requested review from hantangwangd and a team as code owners February 7, 2025 22:26
@ZacBlanco ZacBlanco requested a review from jaystarshot February 7, 2025 22:26
@ZacBlanco ZacBlanco merged commit 11adb6e into prestodb:master Feb 10, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants