Patch libaio.so for testing-mysql-server-8 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacBlanco
force-pushed
the
fix-ubuntu-24
branch
2 times, most recently
from
33ea327 to
e2146bc
Compare
|
Still needs testing |
ZacBlanco
force-pushed
the
fix-ubuntu-24
branch
from
e2146bc to
0befd32
Compare
|
Successfully ran on ubuntu 22 and 24. I don't have a centos machine to test in |
ZacBlanco
force-pushed
the
fix-ubuntu-24
branch
8 times, most recently
from
170c7f1 to
afd908f
Compare
|
I have verified the CI works on my fork in ZacBlanco#1 |
wanglinsong
reviewed
Jan 9, 2025
wanglinsong
reviewed
Jan 9, 2025
use patchelf to overwrite the binary section to a more commonly found name
ZacBlanco
force-pushed
the
fix-ubuntu-24
branch
from
afd908f to
c83b936
Compare
wanglinsong
approved these changes
Jan 9, 2025
|
@rschlussel / @tdcmeehan thoughts on this solution? |
|
@ZacBlanco is it possible to support starting mysql service with user root? User root does not work by default. |
This change sets the mysql --user flag to Java's user.name property which should allow this library to be more flexible when used within containers that use the root user
|
The latest change in 1fc6ccb should allow starting as root |
tdcmeehan
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #26
This repository no longer builds properly due to updated MySQL download URLs. The first two commits add CI and solve build issues. The final commit is the compatibility fix for ubuntu 24.
The fix is to patch the mysql binary to instead look for
libaio.sooverlibaio.so.1.libaio.sois the standard unversioned name of the library that is included with the development headers of libaio.This change will require linux environments which use this library to have the
libaio-dev[el]package installed. It already requireslibnuma1andlibaio1previously, so I don't think it's too big of an ask.The plan after this PR merges would be to update the dependency in prestodb from
testing-mysql-server-5totesting-mysql-server-8. I think we should consider removing thetesting-mysql-server-5module from this project since MySQL 5 is EOL at this point