Ensure Alignment for Map Events #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
confirmed to fix the problem on my machine (can interact with objects in pallet town house, etc) |
ShadowXeldron
added a commit
to ShadowXeldron/pokefirered-xeldromix
that referenced
this pull request
Nov 30, 2023
Ensure Alignment for Map Events (pret#649)
lucasrsa
pushed a commit
to lucasrsa/pokefirered
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discovered, map event scripts must be aligned to 4 bytes; this happens naturally in vanilla, so there were never any explicit alignment directives added, but when using the modern linkerscript, there is no such guarantee. The alignment is now guaranteed in two places: both at the start of the overall map event data blob and at the start of each map
events.incfile. Theoretically, just aligning the data blob should be enough to ensure alignment for every map script, so this may be excessive, but it could be helpful if someone does some weird unlikely change down the line (though I fail to think of a use case that would necessitate such a change).