Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inline ControlGroup examples to reflow #898

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Allow inline ControlGroup examples to reflow #898

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b86fcad
wrap inline ControlGroup examples
joshfarrant Jan 21, 2025
7ed87de
reduce rowGap
joshfarrant Jan 21, 2025
cff4ee8
Revert "reduce rowGap"
joshfarrant Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/docs/content/components/CheckboxGroup/react.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,13 @@ When space is limited, checkboxes can be arranged horizontally using the [Stack]
<CheckboxGroup.Caption>
Some inline checkboxes with a visually hidden label
</CheckboxGroup.Caption>
<Stack direction="horizontal" gap="normal" padding="none">
<Stack
direction="horizontal"
gap="normal"
padding="none"
flexWrap="wrap"
style={{rowGap: 'var(--base-size-8)'}}
>
<FormControl>
<FormControl.Label>Choice one</FormControl.Label>
<Checkbox value="one" />
Expand Down
8 changes: 7 additions & 1 deletion apps/docs/content/components/RadioGroup/react.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,13 @@ When space is limited, radio inputs can be arranged horizontally using the [Stac
<CheckboxGroup.Caption>
Some inline radio inputs with a visually hidden label
</CheckboxGroup.Caption>
<Stack direction="horizontal" gap="normal" padding="none">
<Stack
direction="horizontal"
gap="normal"
padding="none"
flexWrap="wrap"
style={{rowGap: 'var(--base-size-8)'}}
>
<FormControl>
<FormControl.Label>Last 7 days</FormControl.Label>
<Radio name="period" value="week" />
Expand Down
8 changes: 7 additions & 1 deletion packages/react/src/forms/CheckboxGroup/CheckboxGroup.examples.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ export const Inline: Story = {
<CheckboxGroup.Label visuallyHidden={labelVisuallyHidden}>{labelChildren}</CheckboxGroup.Label>
{captionChildren ? <CheckboxGroup.Caption>{captionChildren}</CheckboxGroup.Caption> : null}

<Stack direction="horizontal" gap="normal" padding="none">
<Stack
direction="horizontal"
gap="normal"
padding="none"
flexWrap="wrap"
style={{rowGap: 'var(--base-size-8)'}}
>
<FormControl>
<FormControl.Label>Choice one</FormControl.Label>
<Checkbox value="one" defaultChecked />
Expand Down
8 changes: 7 additions & 1 deletion packages/react/src/forms/RadioGroup/RadioGroup.examples.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ export const Inline: Story = {
<RadioGroup.Label visuallyHidden={labelVisuallyHidden}>{labelChildren}</RadioGroup.Label>
{captionChildren ? <RadioGroup.Caption>{captionChildren}</RadioGroup.Caption> : null}

<Stack direction="horizontal" gap="normal" padding="none">
<Stack
direction="horizontal"
gap="normal"
padding="none"
flexWrap="wrap"
style={{rowGap: 'var(--base-size-8)'}}
>
<FormControl>
<FormControl.Label>0-99</FormControl.Label>
<Radio name="demo" value="one" />
Expand Down
Loading