Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionMenu falsy value bugfix #912

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

joshfarrant
Copy link
Contributor

@joshfarrant joshfarrant commented Jan 29, 2025

Summary

Removes check for truthiness in handleItemSelection in ActionMenu.tsx to allow falsy values to trigger item selection callback.

List of notable changes:

  • ActionMenu.tsx: Removed check for truthiness in handleItemSelection to allow falsy values to trigger item selection callback.
  • ActionMenu.test.tsx: Added a test to assert that falsy items can be selected

Steps to test:

  1. Open the ActionMenu Docs
  2. Edit the first example to set one of the values to ""
  3. Open the ActionMenu and click on the item associated with that value
  4. Observe that the onSelect callback is called and triggers an alert.

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 80828fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 29, 2025

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Jan 29, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@joshfarrant joshfarrant marked this pull request as ready for review January 29, 2025 12:01
@joshfarrant joshfarrant changed the title Joshfarrant/actionmenu falsey item Joshfarrant/actionmenu falsy item Jan 29, 2025
@joshfarrant joshfarrant requested a review from rezrah January 29, 2025 12:04
@joshfarrant joshfarrant changed the title Joshfarrant/actionmenu falsy item ActionMenu falsy value bugfis Jan 31, 2025
@joshfarrant joshfarrant changed the title ActionMenu falsy value bugfis ActionMenu falsy value bugfix Jan 31, 2025
@joshfarrant joshfarrant merged commit 5966728 into main Feb 3, 2025
17 checks passed
@joshfarrant joshfarrant deleted the joshfarrant/actionmenu-falsey-item branch February 3, 2025 13:18
@primer-css primer-css mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - ActionMenu ignores items whose value is falsy
2 participants