-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActionMenu falsy value bugfix #912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 80828fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
joshfarrant
temporarily deployed
to
github-pages
January 29, 2025 10:40 — with
GitHub Actions
Inactive
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
joshfarrant
changed the title
Joshfarrant/actionmenu falsey item
Joshfarrant/actionmenu falsy item
Jan 29, 2025
joshfarrant
changed the title
Joshfarrant/actionmenu falsy item
ActionMenu falsy value bugfis
Jan 31, 2025
joshfarrant
changed the title
ActionMenu falsy value bugfis
ActionMenu falsy value bugfix
Jan 31, 2025
rezrah
reviewed
Jan 31, 2025
rezrah
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes check for truthiness in
handleItemSelection
inActionMenu.tsx
to allow falsy values to trigger item selection callback.List of notable changes:
ActionMenu.tsx
: Removed check for truthiness inhandleItemSelection
to allow falsy values to trigger item selection callback.ActionMenu.test.tsx
: Added a test to assert that falsy items can be selectedSteps to test:
""
onSelect
callback is called and triggers an alert.Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist: