Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface guidelines for Breadcrumbs component #915

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add interface guidelines for Breadcrumbs component #915

wants to merge 8 commits into from

Conversation

danielguillan
Copy link
Contributor

@danielguillan danielguillan commented Jan 30, 2025 •
edited
Loading

Summary

Adds new interface guidelines for the Breadcrumbs component.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f227492

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

🟢 No design token changes found

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@danielguillan danielguillan mentioned this pull request Jan 30, 2025
Closed
9 tasks
joshfarrant
joshfarrant approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@joshfarrant joshfarrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

apps/docs/content/components/Breadcrumbs/react.mdx Show resolved Hide resolved
@danielguillan danielguillan requested a review from rezrah January 31, 2025 14:47
rezrah
rezrah reviewed Jan 31, 2025
View reviewed changes
apps/docs/content/components/Breadcrumbs/images/variants.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real nit here, sorry...

In the docs, this almost looks like a 404 image showing alt text 😄

👇

Screenshot 2025-01-31 at 17 48 03

@danielguillan do you think we can either center the breadcrumbs or put it on a gray background like the images below?

rezrah
rezrah approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @danielguillan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rezrah rezrah rezrah approved these changes

@joshfarrant joshfarrant joshfarrant approved these changes

@jesussandreas jesussandreas Awaiting requested review from jesussandreas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielguillan @joshfarrant @rezrah