Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Eliminate deprecation warning of context.getScope #188

Merged
merged 1 commit into from
May 30, 2024

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented May 29, 2024

I keep getting deprecation notices when I run the tests.

This PR gets rid of the warnings by migrates away from the deprecated syntax, context.getScope(). I followed the guidance in ESLint for context.getScope. ✨

 PASS  src/rules/__tests__/no-deprecated-entrypoints.test.js
(node:11722) DeprecationWarning: "a11y-explicit-heading" rule is using `context.getScope()`, which is deprecated and will be removed in ESLint v9. Please use `sourceCode.getScope()` instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
 PASS  src/rules/__tests__/a11y-explicit-heading.test.js
 PASS  src/rules/__tests__/no-deprecated-props.test.js
(node:11721) DeprecationWarning: "direct-slot-children" rule is using `context.getScope()`, which is deprecated and will be removed in ESLint v9. Please use `sourceCode.getScope()` instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
 PASS  src/rules/__tests__/direct-slot-children.test.js
(node:11719) DeprecationWarning: "no-system-props" rule is using `context.getScope()`, which is deprecated and will be removed in ESLint v9. Please use `sourceCode.getScope()` instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
 PASS  src/rules/__tests__/no-system-props.test.js
 PASS  src/rules/__tests__/new-color-css-vars.test.js
(node:11717) DeprecationWarning: "non-interactive-tooltip-trigger" rule is using `context.getScope()`, which is deprecated and will be removed in ESLint v9. Please use `sourceCode.getScope()` instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

@khiga8 khiga8 requested a review from a team as a code owner May 29, 2024 00:55
@khiga8 khiga8 requested a review from siddharthkp May 29, 2024 00:55
Copy link

changeset-bot bot commented May 29, 2024

⚠️ No Changeset found

Latest commit: eb2d4aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@siddharthkp siddharthkp merged commit 9f9cfd2 into main May 30, 2024
10 of 11 checks passed
@siddharthkp siddharthkp deleted the kh-migrate-deprecated branch May 30, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants