Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enforce-css-module-identifier-casing rule #258

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

keithamus
Copy link
Member

Closes https://github.com/github/primer/issues/4248

This rule disallows the use of any CSS Module property that does not match the desired casing.

@keithamus keithamus requested a review from a team as a code owner October 18, 2024 13:54
@keithamus keithamus requested a review from jonrohan October 18, 2024 13:54
Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: 560e3b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@keithamus keithamus force-pushed the add-enforce-css-module-identifier-casing-rule branch from 38caa8e to 4ade79f Compare October 18, 2024 13:55
src/utils/casing-matches.js Dismissed Show dismissed Hide dismissed
src/utils/casing-matches.js Dismissed Show dismissed Hide dismissed
src/utils/casing-matches.js Fixed Show fixed Hide fixed
src/utils/casing-matches.js Dismissed Show dismissed Hide dismissed
src/utils/casing-matches.js Dismissed Show dismissed Hide dismissed
@keithamus keithamus force-pushed the add-enforce-css-module-identifier-casing-rule branch from 4ade79f to d038b48 Compare October 18, 2024 13:59
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to run npm run format to fix that one ci error

@keithamus keithamus enabled auto-merge (squash) October 24, 2024 11:11
@keithamus keithamus merged commit 83f29f3 into main Oct 24, 2024
7 checks passed
@keithamus keithamus deleted the add-enforce-css-module-identifier-casing-rule branch October 24, 2024 11:12
@primer-css primer-css mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants