Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove husky from project #5133

Merged
merged 1 commit into from
Oct 16, 2024
Merged

chore: remove husky from project #5133

merged 1 commit into from
Oct 16, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Oct 16, 2024 •
edited
Loading

This was enabled recently with an upgrade and it has been annoying 😅 Removing this unless folks have a strong desire to keep it in.

Changelog

New

Changed

Removed

  • Remove husky and lint-staged

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 1dcd7ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 16, 2024
langermank
langermank approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU YES

@joshblack joshblack added the skip changeset This change does not need a changelog label Oct 16, 2024
@joshblack joshblack marked this pull request as ready for review October 16, 2024 16:16
@joshblack joshblack requested a review from a team as a code owner October 16, 2024 16:16
@joshblack joshblack requested a review from mperrotti October 16, 2024 16:16
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.59 KB (0%)
packages/react/dist/browser.umd.js 97.84 KB (0%)

@joshblack joshblack added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 7b025d9 Oct 16, 2024
50 of 51 checks passed
@joshblack joshblack deleted the chore/remove-husky branch October 16, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @langermank