feat(ActionMenu): add IconButton anchor #5586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 207015b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
approved these changes
Jan 21, 2025
francinelucca
changed the title
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358748 |
github-actions
bot
added
integration-tests: failing
|
🔴 golden-jobs completed with status |
joshblack
approved these changes
Jan 22, 2025
|
closing, documented in https://github.com/github/primer/issues/4716 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
IconButtonsubcomponent toActionMenuand examples for usage ofActionMenus inside ofActionBar.Changelog
New
IconButtonsubcomponent toActionMenuRollout strategy
Docs only update
Testing & Reviewing
https://primer-cc34192cf0-13348165.drafts.github.io/storybook/?path=/story/experimental-components-actionbar-examples--with-action-menu
https://primer-cc34192cf0-13348165.drafts.github.io/storybook/?path=/story/experimental-components-actionbar-examples--with-action-menu-as-icon
Merge checklist