Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Dialog stress test story to go fullscreen on narrow screens #5628

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

hectahertz
Copy link
Contributor

Part of the work to improve reflow of the component. This helps not hide the content on small screens and represents correct usage of the Dialog component by consumers for a case like this.

Changelog

Changed

Updates the Dialog stress test story to go fullscreen on narrow screens.

Before:

primer style_react_storybook__path=_story_components-pagination--playground args=currentPage_1

After:

localhost_6006__path=_story_components-dialog-features--stress-test

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hectahertz hectahertz requested a review from a team as a code owner January 30, 2025 18:32
@hectahertz hectahertz requested a review from mperrotti January 30, 2025 18:32
Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: bf90138

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.56 KB (+0.14% 🔺)
packages/react/dist/browser.umd.js 104.89 KB (+0.05% 🔺)

@hectahertz hectahertz added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 621c878 Feb 7, 2025
49 checks passed
@hectahertz hectahertz deleted the hectahertz/update-dialog-stress-test-story branch February 7, 2025 12:49
@primer primer bot mentioned this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants