Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionMenu: Ensure custom overlay is responsive #5654

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Feb 4, 2025

Context: https://github.com/github/accessibility-audits/issues/10002

Ensures that the custom Overlay in ActionMenu's example is responsive, via the preventOverflow prop.

Changelog

Changed

  • Adds preventOverflow prop to ActionMenu example so that the custom Overlay is responsive
  • Adds newline to docs for Overlay

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@TylerJDev TylerJDev requested a review from a team as a code owner February 4, 2025 14:15
@TylerJDev TylerJDev requested a review from jonrohan February 4, 2025 14:15
Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: efb73cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.57 KB (0%)
packages/react/dist/browser.umd.js 106.04 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5654 February 4, 2025 14:29 Inactive
@TylerJDev TylerJDev enabled auto-merge February 4, 2025 21:23
@TylerJDev TylerJDev added this pull request to the merge queue Feb 13, 2025
@joshblack joshblack removed this pull request from the merge queue due to a manual request Feb 13, 2025
@TylerJDev TylerJDev added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@TylerJDev TylerJDev added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 102b523 Feb 13, 2025
44 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/add-overflow-prop-to-example-action-menu branch February 13, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants