Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Update preview to give each input field a unique ID + add aria-label to leading visual #3300

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

kendallgassner
Copy link
Contributor

@kendallgassner kendallgassner commented Jan 29, 2025

What are you trying to accomplish?

Closes:

Screenshots

N/A

Integration

N/A

List the issues that this change affects.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.

What approach did you choose and why?

This PR updates the IDs of each input field on the TextField Options preview so that they are unique. Unique IDs are important for screen readers to properly match labels with input fields.

I also have added an aria-label to the search icon leading visual in the TextField Options preview .

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome (+ NVDA)
  • Tested in Firefox
  • Tested in Safari (+ VoiceOver)
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@kendallgassner kendallgassner added the skip changeset Pull requests that don't change the library output label Jan 29, 2025
@kendallgassner kendallgassner requested a review from a team as a code owner January 29, 2025 20:44
Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: 6afb34a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kendallgassner kendallgassner changed the title [Accessibility] Give each input field a unique ID [Accessibility] Update preview to give each input field a unique ID + add aria-label to leading visual Jan 29, 2025
Copy link
Contributor

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

@github-actions github-actions bot requested a review from a team as a code owner January 29, 2025 21:17
@github-actions github-actions bot requested a review from tbenning January 29, 2025 21:17
@kendallgassner kendallgassner merged commit 08581ce into main Jan 30, 2025
34 checks passed
@kendallgassner kendallgassner deleted the kendallg/give-textfield-story-unique-input-ids branch January 30, 2025 20:16
@camertron
Copy link
Contributor

Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants