Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelativeTime: Remove title from Lookbook previews #3326

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Feb 11, 2025

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Context https://github.com/github/accessibility-audits/issues/10169, https://github.com/github/primer/issues/4769

Integration

No

List the issues that this change affects.

https://github.com/github/accessibility-audits/issues/10169

Removes title from RelativeTime previews via the no_title argument.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 633aabc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TylerJDev TylerJDev added the skip changeset Pull requests that don't change the library output label Feb 11, 2025
@TylerJDev TylerJDev marked this pull request as ready for review February 11, 2025 13:51
@TylerJDev TylerJDev requested a review from a team as a code owner February 11, 2025 13:51
@TylerJDev TylerJDev requested a review from joshblack February 11, 2025 13:51
@TylerJDev TylerJDev merged commit 6afe922 into main Feb 11, 2025
46 of 47 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/remove-relative-time-element-title branch February 11, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants