-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Markdown preview examples to include tabindex #3330
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with non-blocking comment.
Also thank you for starting that discussion. It would be great if we could also improve the code blocks!
@@ -47,7 +47,7 @@ class MarkdownPreview < ViewComponent::Preview | |||
<h6>Header 6</h6> | |||
<table> | |||
<table tabindex="0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that this table and the second one are smaller than the last table. Do we still need tabindex
on them? Wasn't sure if the scrollbar still appears 🤔
What are you trying to accomplish?
List the issues that this change affects.
Relates to:
Risk Assessment
What approach did you choose and why?
Given this component is purely presentational, I hesitate to add JS behaviors to it since it's already used in places that might already be providing JS behaviors. I opted to add a warning to have the consumer handle adding JS behaviors. For example, dotcom has a JS script to handle overflowing tables. (Note: we are still not handling overflow code blocks and I've started a convo with the relevant team. See this discussion thread).
Anything you want to highlight for special attention from reviewers?
Does this approach sound reasonable?
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.