Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Symfony 7.x #19

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

nightio
Copy link
Contributor

@nightio nightio commented Jul 16, 2024

No description provided.

@GromNaN
Copy link
Collaborator

GromNaN commented Jul 16, 2024

Thank you! The tests are failing, do you want to have a look?

@nightio nightio force-pushed the symfony-7.x-support branch from 3d4b79f to 4346943 Compare July 16, 2024 14:02
@nightio nightio force-pushed the symfony-7.x-support branch from 4346943 to ec57ba3 Compare July 16, 2024 15:02
@nightio
Copy link
Contributor Author

nightio commented Jul 16, 2024

@GromNaN I modified the tests.
Could you run it again?

It works on my branch https://github.com/nightio/metrics/actions/runs/9959328699/job/27515923520

If you be able to merge the PR, please create new version :)

@GromNaN GromNaN merged commit b6af001 into prismamedia:2.x Jul 16, 2024
4 checks passed
@GromNaN
Copy link
Collaborator

GromNaN commented Jul 16, 2024

Thank you @nightio. Very appreciated.

@nightio nightio deleted the symfony-7.x-support branch July 16, 2024 15:30
@nightio
Copy link
Contributor Author

nightio commented Jul 16, 2024

@GromNaN no problem 🙂

Could you create a release?

@GromNaN
Copy link
Collaborator

GromNaN commented Jul 16, 2024

Done v2.1.0

@nightio
Copy link
Contributor Author

nightio commented Jul 16, 2024

Thanks 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants