fix: tally result id collision

[kittybest]

Description

This is to solve the tallyResult id collision on the subgraph, meanwhile make sure the interface works well after this change.

Because of the rebase issue, this is same PR as #584 & #583 , but branch from the latest main branch.

Additional Notes

I found that the interface mapping result with tally result never uses the result id, that's why we didn't find this problem before. We need to have 100% confidence that the subgraph returns tally result 1 by 1 following the index of the projects.
(So actually, maybe it's better that we use the result.id instead of the index of the loop?)

see here:

maci-platform/packages/interface/src/server/api/routers/results.ts

Lines 61 to 68 in c0e35af

	const results = tallyData.results.reduce((acc, tally, index) => {
	const project = projects[index];
	if (project) {
	acc.set(project.id, { votes: Number(tally.result), voters: 0 });
	}
	return acc;
	}, new Map<string, { votes: number; voters: number }>());

Related issue(s)

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

• I have read and understand MACI's contributor guidelines and code of conduct.
• I run and verified that all tests pass acording to MACI's testing guide.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
maci-platform	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 21, 2025 6:06pm

[crisgarner]

Thanks! only have a question

[crisgarner]

Thanks!