feat(cross-validation reporter): Remove timing_normalized plot

Closes #1043
probabl-ai · Jan 8, 2025 · cbf30d2 · cbf30d2
1 parent fb95c2e
commit cbf30d2
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 142 deletions.
diff --git a/examples/getting_started/plot_quick_start.py b/examples/getting_started/plot_quick_start.py
@@ -42,9 +42,6 @@
 # %%
 reporter.plots.scores
 
-# %%
-reporter.plots.timing_normalized
-
 # %%
 # Finally, from your shell (in the same directory), start the UI:
 #

diff --git a/skore/src/skore/item/cross_validation_item.py b/skore/src/skore/item/cross_validation_item.py
@@ -344,7 +344,6 @@ def factory(cls, reporter: CrossValidationReporter) -> CrossValidationItem:
         humanized_plot_names = {
             "scores": "Scores",
             "timing": "Timings",
-            "timing_normalized": "Normalized timings",
         }
         plots_bytes = {
             humanized_plot_names[plot_name]: (

diff --git a/skore/src/skore/sklearn/cross_validation/cross_validation_reporter.py b/skore/src/skore/sklearn/cross_validation/cross_validation_reporter.py
@@ -16,7 +16,6 @@
     _strip_cv_results_scores,
 )
 from .plots.compare_scores_plot import plot_cross_validation_compare_scores
-from .plots.timing_normalized_plot import plot_cross_validation_timing_normalized
 from .plots.timing_plot import plot_cross_validation_timing
 
 
@@ -26,7 +25,6 @@ class CrossValidationPlots:
 
     scores: plotly.graph_objects.Figure
     timing: plotly.graph_objects.Figure
-    timing_normalized: plotly.graph_objects.Figure
 
 
 class CrossValidationReporter:
@@ -189,5 +187,4 @@ def plots(self) -> CrossValidationPlots:
         return CrossValidationPlots(
             scores=plot_cross_validation_compare_scores(self._cv_results),
             timing=plot_cross_validation_timing(self._cv_results),
-            timing_normalized=plot_cross_validation_timing_normalized(self._cv_results),
         )
diff --git a/skore/src/skore/sklearn/cross_validation/plots/timing_normalized_plot.py b/skore/src/skore/sklearn/cross_validation/plots/timing_normalized_plot.py
diff --git a/skore/tests/unit/item/test_cross_validation_item.py b/skore/tests/unit/item/test_cross_validation_item.py
@@ -37,7 +37,6 @@ class FakeCrossValidationReporter(CrossValidationReporter):
     plots = CrossValidationPlots(
         scores=plotly.graph_objects.Figure(),
         timing=plotly.graph_objects.Figure(),
-        timing_normalized=plotly.graph_objects.Figure(),
     )
     cv = StratifiedKFold(n_splits=5)
 
@@ -59,7 +58,6 @@ class FakeCrossValidationReporterNoGetParams(CrossValidationReporter):
     plots = CrossValidationPlots(
         scores=plotly.graph_objects.Figure(),
         timing=plotly.graph_objects.Figure(),
-        timing_normalized=plotly.graph_objects.Figure(),
     )
     cv = StratifiedKFold(n_splits=5)
-Original file line number
+Diff line change
@@ Expand Up / @@ -42,9 +42,6 @@ @@
     # %%
     reporter.plots.scores
-    # %%
-    reporter.plots.timing_normalized
     # %%
     # Finally, from your shell (in the same directory), start the UI:
     #
@@ Expand Down @@