Skip to content

Commit

Permalink
chore: complete the tests
Browse files Browse the repository at this point in the history
  • Loading branch information
MarieS-WiMLDS committed Jan 21, 2025
1 parent d379133 commit cef1caa
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
3 changes: 3 additions & 0 deletions skore/src/skore/project/project.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from typing import TYPE_CHECKING, Any, Literal, Optional, Union

from skore.persistence.item import item_to_object, object_to_item
from skore.persistence.view.view import View

if TYPE_CHECKING:
from skore.persistence import (
Expand Down Expand Up @@ -280,3 +281,5 @@ def clear(self):
self.delete(item_key)
for view_key in self.view_repository:
self.view_repository.delete_view(view_key)
# recreate default view
self.view_repository.put_view("default", View(layout=[]))
9 changes: 8 additions & 1 deletion skore/tests/unit/project/test_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
InvalidProjectNameError,
ProjectCreationError,
)
from skore.persistence.view.view import View
from skore.project.create import _create, _validate_project_name


Expand Down Expand Up @@ -267,10 +268,16 @@ def test_put_wrong_key_and_value_raise(in_memory_project):


def test_clear(in_memory_project):
in_memory_project.put("an int", 1)
in_memory_project.put("key1", 1)
in_memory_project.put("key1", 2)
in_memory_project.put("a str", "some text here to have fun")
in_memory_project.view_repository.put_view(
"default_test_", View(layout=["key1", "key2"])
)
in_memory_project.clear()
assert len(in_memory_project.keys()) == 0
assert len(in_memory_project.view_repository.keys()) == 1
assert in_memory_project.view_repository.keys()[0] == "default"


test_cases = [
Expand Down

0 comments on commit cef1caa

Please sign in to comment.