Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): Join sidebar sections #1094

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

augustebaum
Copy link
Contributor

@augustebaum augustebaum commented Jan 13, 2025

Closes #1077

Screenshot:

2025-01-13T12_14_04_screenshot

@sylvaincom
Copy link
Contributor

sylvaincom commented Jan 13, 2025

Hi @augustebaum I don't understand exactly what this PR does and how it closes issue #1077? Did you see my comment at #1077 (comment)? Or maybe I do a separate issue for my comment?

@augustebaum
Copy link
Contributor Author

augustebaum commented Jan 13, 2025

Hi @augustebaum I don't understand exactly what this PR does and how it closes issue #1077? Did you see my comment at #1077 (comment)?

I read the suggested improvement ("Put it under the menu "ML Assistance"") as meaning "Remove the "Reporting for a single estimator"" heading; so now the sidebar has 2 sections instead of 3.

@sylvaincom
Copy link
Contributor

Ok, I create a new issue for my comment

@sylvaincom sylvaincom self-requested a review January 13, 2025 11:33
Copy link
Contributor

@sylvaincom sylvaincom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@thomass-dev
Copy link
Collaborator

thomass-dev commented Jan 13, 2025

@augustebaum have you tried to build locally the documentation? If so, i can merge your PR.

Copy link
Collaborator

@thomass-dev thomass-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick look at the dependencies.

@augustebaum
Copy link
Contributor Author

@augustebaum have you tried to build locally the documentation? If so, i can merge your PR.

Yes

@thomass-dev thomass-dev merged commit db07089 into main Jan 13, 2025
8 of 9 checks passed
@thomass-dev thomass-dev deleted the 1077-join-sidebar-sections branch January 13, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: Improve API for Estimator report menu
3 participants