-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api): Join sidebar sections #1094
Conversation
Hi @augustebaum I don't understand exactly what this PR does and how it closes issue #1077? Did you see my comment at #1077 (comment)? Or maybe I do a separate issue for my comment? |
I read the suggested improvement ("Put it under the menu "ML Assistance"") as meaning "Remove the "Reporting for a single estimator"" heading; so now the sidebar has 2 sections instead of 3. |
Ok, I create a new issue for my comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@augustebaum have you tried to build locally the documentation? If so, i can merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick look at the dependencies.
Yes |
Closes #1077
Screenshot: