Confine the unique_entities flag to where it's relevant in incorporate. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxx/gendb.cc
Outdated
| if (!reference_values.at(domains[ind]).contains({rf_name, class_item})) { | ||
| int new_val; | ||
| const std::string& ref_class = domains.at(rf_ind); | ||
| if (domain_crps.at(ref_class).tables.size() == 0) { |
There was a problem hiding this comment.
This can be simplified after #222 is submitted.
|
The nested if and for isn't great, but I'd rather have the complexity confined to a single method than plumb an arg through whose purpose is confusing in most of the methods, and will result in weird subtle bugs if someone passes "true" from anywhere but the call in "incorporate". |
emilyfertig
force-pushed
the
093024-emilyaf-inference_gendb
branch
from
e9e5ce8 to
7aecc4b
Compare
…through methods that it isn't relevant to.
emilyfertig
force-pushed
the
100124-emilyaf-unique-entities
branch
from
bc575d2 to
7aa4920
Compare
|
I looked at this again, and especially with crp.max_table, the complexity of the new function isn't that bad so I'm going to merge it to better separate concerns between initialization with unique entities/inference where we want CRP samples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diffbase is the inference_gendb branch.