-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links to point to tutorial page #7318
Update links to point to tutorial page #7318
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking on this task. When you run grunt yui:dev, it should start the reference website with the updated code and examples. However, I'm still encountering a broken link when I try to run it. Could you please verify the correct path?
Additionally, I'm unsure if we have the tutorial page included in the p5.js repository. If it’s missing, we might need to use absolute URLs, such as:
<a href="https://p5js.org/tutorials/writing-accessible-canvas-descriptions/">Writing accessible canvas descriptions</a>
I think the relative path from |
The old link is broken and this seems like the proper one. Addresses p5.js-website#527
fc137e6
to
30f10f1
Compare
Thanks very much for the feedback! I've switched this to an absolute link, and I properly built/tested locally, and I believe everything is working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really sorry for the delay in the review. LGTM, thanks for your work and your patience.
Addresses processing/p5.js-website#527
Changes:
The link to the page about creating accessible labels is broken and this seems like the proper one.
Screenshots of the change:
PR Checklist
npm run lint
passes