Make patch route #10 #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test to patch user comments routes - Add fixture for this tests - Add enable set anonym to patch comment
|
💩 Code linting failed, use |
Coverage Report
Summary
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Temmmmmo
reviewed
Nov 24, 2024
Temmmmmo
reviewed
Nov 24, 2024
- Fix up tests - Make allow unnecessary attibutes to patch - Add new scheme to CommentUpdate
DaymasS
reviewed
Nov 24, 2024
Zimovchik
requested changes
Nov 25, 2024
Temmmmmo
reviewed
Dec 1, 2024
- Validation if given attribute is still not changed - Validation if no attributes given - Add tests
|
💩 Code linting failed, use |
Zimovchik
reviewed
Dec 6, 2024
parfenovma
reviewed
Dec 6, 2024
| @@ -133,7 +133,7 @@ async def get_comments( | |||
| return result | |||
|
|
|||
|
|
|||
| @comment.patch("/{uuid}", response_model=CommentGet) | |||
| @comment.patch("/{uuid}/review", response_model=CommentGet) | |||
There was a problem hiding this comment.
warning!
надо поддерджать это на Фронте, перед выкаткой напишите Илье Батуеву
parfenovma
approved these changes
Dec 9, 2024
Zimovchik
approved these changes
Dec 9, 2024
Temmmmmo
requested changes
Dec 10, 2024
| raise HTTPException(status_code=409, detail="Provide any parametr") # 409 | ||
|
|
||
| # Если хоть одно поле было передано неизменным | ||
| if set(comment.__dict__.items()).intersection(set(comment_update.model_dump(exclude_unset=True).items())): |
There was a problem hiding this comment.
можно и так, но я бы запрос в базу сделал просто через filter
если вернется объект, где все поля идентичны заданному, то тогда возвращать 409
|
|
||
| # Если хоть одно поле было передано неизменным | ||
| if set(comment.__dict__.items()).intersection(set(comment_update.model_dump(exclude_unset=True).items())): | ||
| raise HTTPException(status_code=426, detail="No changes detected") # 426 |
There was a problem hiding this comment.
426 не подходит, она про другое
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения #10
ВАЖНО: изменена ручка для patch/review комментария админами
Чтобы изменить комментарий ему нужно отправить все поля для схемы CommentPost, их можно предварительно получить из GET, и в комментарии перепишутся поля. Также можно сделать комментарий анонимным через PATCH.
Детали реализации
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?