Skip to content

Commit

Permalink
test for permissions
Browse files Browse the repository at this point in the history
Signed-off-by: Marcel Bindseil <[email protected]>
  • Loading branch information
bindsi committed Jan 22, 2025
1 parent dcfe306 commit e8ffe39
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions discovery-handlers/udev/src/discovery_handler.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ use akri_discovery_utils::discovery::{
};
use async_trait::async_trait;
use log::{error, info, trace};
use serde::{de, Deserialize, Deserializer};
use std::collections::{HashMap, HashSet};
use std::time::Duration;
use tokio::sync::mpsc;
use tokio::time::sleep;
use tonic::{Response, Status};
use serde::{Deserialize, Deserializer, de};

// TODO: make this configurable
pub const DISCOVERY_INTERVAL_SECS: u64 = 10;
Expand Down Expand Up @@ -210,7 +210,6 @@ mod tests {
let expected_deserialized =
r#"{"udevRules":[],"groupRecursive":false,"permissions":"rwm"}"#;
assert_eq!(expected_deserialized, serialized);

}

#[test]
Expand All @@ -227,14 +226,20 @@ mod tests {
}

#[test]
#[should_panic]
fn test_deserialize_discovery_details_permissions_invalid() {
let yaml = r#"
udevRules:
- 'KERNEL=="video[0-9]*"'
permissions: xyz
"#;
assert_eq!(deserialize_discovery_details(yaml).unwrap(), Err(de::Error::invalid_value(
de::Unexpected::Str(&value),
&"a valid permission combination ('r', 'w', 'm', 'rw', 'rm', 'rwm', 'wm')",
)));}
let config: UdevDiscoveryDetails = deserialize_discovery_details(yaml).unwrap();
// assert_eq!(
// deserialize_discovery_details(yaml).unwrap(),
// Err(de::Error::invalid_value(
// de::Unexpected::Str(&value),
// &"a valid permission combination ('r', 'w', 'm', 'rw', 'rm', 'rwm', 'wm')",
// ))
// );
}
}

0 comments on commit e8ffe39

Please sign in to comment.