Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): show a message while results are loading for dynamic search #2134

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

andaaron
Copy link
Contributor

See project-zot/zui#397

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@44dfa8a). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2134   +/-   ##
=======================================
  Coverage        ?   92.06%           
=======================================
  Files           ?      165           
  Lines           ?    28681           
  Branches        ?        0           
=======================================
  Hits            ?    26406           
  Misses          ?     1678           
  Partials        ?      597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andaaron andaaron marked this pull request as ready for review December 12, 2023 10:00
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 86b0a22 into project-zot:main Dec 13, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants