feat(sync): use regclient for sync extension #2903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2903 +/- ##
==========================================
- Coverage 91.04% 91.01% -0.04%
==========================================
Files 174 168 -6
Lines 32644 31818 -826
==========================================
- Hits 29722 28960 -762
+ Misses 2209 2147 -62
+ Partials 713 711 -2 ☔ View full report in Codecov by Sentry. |
andaaron
reviewed
Jan 21, 2025
eusebiu-constantin-petu-dbk
force-pushed
the
sync_regclient_2
branch
2 times, most recently
from
f8f5eac to
f3fb1fe
Compare
eusebiu-constantin-petu-dbk
requested review from
shimish2 and
rchincha
as code owners
eusebiu-constantin-petu-dbk
changed the title
andaaron
previously approved these changes
Jan 24, 2025
rchincha
reviewed
Jan 25, 2025
|
@eusebiu-constantin-petu-dbk conflicts? sorry |
eusebiu-constantin-petu-dbk
force-pushed
the
sync_regclient_2
branch
5 times, most recently
from
ab8c8f7 to
a2cf04c
Compare
andaaron
reviewed
Jan 31, 2025
|
There are test failures. |
eusebiu-constantin-petu-dbk
force-pushed
the
sync_regclient_2
branch
7 times, most recently
from
21769c4 to
79e5536
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
sync_regclient_2
branch
3 times, most recently
from
42b26f1 to
21769c4
Compare
andaaron
reviewed
Feb 1, 2025
eusebiu-constantin-petu-dbk
force-pushed
the
sync_regclient_2
branch
from
eb69c32 to
fd65c7e
Compare
replaced containers/image package with regclient/regclient package Signed-off-by: Eusebiu Petu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
sync_regclient_2
branch
from
fd65c7e to
f0d5fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced containers/image package with regclient/regclient package
What type of PR is this?
refactor
Which issue does this PR fix:
Doesn't fix anything, just uses another library for sync
What does this PR do / Why do we need it:
More unified sync logic without separate code fore referrers, catalog etc.
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
No
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.