Compute Matched filter power #192
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves all function definitions to the cc file
Modifies the functions accepting KTFrequencySpectrumFFTW types
Modifications of the arithmetic operators to enable full compatibility for child classes
The function returns the norm of a bin, i.e. the square of the absolute value without any unnecessary calculations of squareroots.
The FFT processors now take the modified KTFrequencySpectrumFFTW. The call to the FFTW routine is now done with the data pointer of the Eigen object which is cast to be a fftw_complex*
Mostly modifies a few lines per file that did applied operations specifig to fftw_complex
Removes the copy constructor to replace it with the default one
Applies the rule of zero
Missing address operator
They now also take std::complex for the timeseries objects
Mostly modifies a few lines per file that applied operations specific to fftw_complex
This fixes an issue for reading multiple egg files. After the first egg file the reader did only read a single time slice per file.
Makes functions public that were accidentally protected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review yet.