Fix filenames of static libraries. #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were missing the "-4" suffix, and the static playlist library also used underscores instead of dashes.
Will avoid making errors in future versions. Include dirs still are hard-coded, as they partially exist as paths in the source tree.
Blaquewithaq
approved these changes
Oct 6, 2023
revmischa
approved these changes
Oct 6, 2023
|
So we can install different major versions at the same time. Since not all operating systems support SO versions, specifically Windows, this may cause conflicts in some (rare) circumstances. Besides that, it's not really relevant in any way, but having the -4 in there doesn't hurt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were missing the "-4" suffix, and the static playlist library also used underscores instead of dashes.