[STUD-349, MRKT-161]: numeric input fixes (#740)

* updates numeric input functionality * adds placeholder to sale input
projectNEWM · Oct 10, 2024 · 7254ef3 · 7254ef3
1 parent 8a67bcb
commit 7254ef3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/apps/marketplace/src/components/Sale.tsx b/apps/marketplace/src/components/Sale.tsx
@@ -281,7 +281,11 @@ const Sale: FunctionComponent<SaleProps> = ({
                         </Typography>
                         <Stack direction={ "row" }>
                           <Box maxWidth={ "150px" }>
-                            <TextInputField name="streamTokens" type="number" />
+                            <TextInputField
+                              name="streamTokens"
+                              placeholder="0"
+                              type="number"
+                            />
                           </Box>
                           <Typography
                             alignSelf="center"

diff --git a/packages/elements/src/lib/NumericInput.tsx b/packages/elements/src/lib/NumericInput.tsx
@@ -30,11 +30,13 @@ export const NumericInput: ForwardRefRenderFunction<
    */
   const handleChange = (event: ChangeEvent<HTMLInputElement>) => {
     if (onChange) {
-      const formattedValue = event.target.value.replace(/,/g, "");
-      const numberValue = Number(formattedValue);
+      const value = event.target.value;
+      const numberValue = value ? Number(value.replace(/,/g, "")) : null;
 
-      event.target.type = "number";
-      event.target.valueAsNumber = numberValue;
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      const newTarget = event.target as any;
+      newTarget.value = numberValue;
+      event.target = newTarget;
 
       onChange(event);
     }