Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Updated role defaults to cover undefined cases #616

Merged
merged 1 commit into from
May 13, 2024

Conversation

escobarjonatan
Copy link
Contributor

bug.mov

@escobarjonatan escobarjonatan requested a review from scandycuz May 12, 2024 19:06
@escobarjonatan escobarjonatan self-assigned this May 12, 2024
const queryExactlyMatchesTag = tag === query;
const tagIncludesQuery = tag.toLowerCase().includes(query.toLowerCase());
const filterTags =
(query = "") =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to tell but this was the only change made here:
from:
(query: string)
to:
(query = "")

Copy link

Visit the preview URL for this PR (updated for commit 0143e70):

https://newm-artist-portal--pr616-bugfix-signup-role-8zgakrzc.web.app

(expires Tue, 11 Jun 2024 19:08:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec3483d4c62309afc398865bfd6a9fc9e03e1d46

Copy link

Visit the preview URL for this PR (updated for commit 0143e70):

https://fan-square--pr616-bugfix-signup-role-vymuezmw.web.app

(expires Tue, 11 Jun 2024 19:08:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b38f4676e459f355dcb11c95730012d43389bfd2

Copy link

Visit the preview URL for this PR (updated for commit a717e1e):
🚀 https://xfwjj7ot53g6nn2tylzvycgsbm0biyhm.lambda-url.us-west-2.on.aws/

Copy link
Contributor

@dmkirshon dmkirshon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@escobarjonatan escobarjonatan merged commit bb3128c into master May 13, 2024
6 checks passed
@escobarjonatan escobarjonatan deleted the bugfix/signup-role branch May 13, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants