-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes #633
Misc fixes #633
Conversation
scandycuz
commented
May 19, 2024
- Updates song card price layout to stack vertically.
- limits "More from {artist}" and "Similar songs" to 8 songs to not make it difficult to scroll to other sections. Post-MVP, some sort of "View all" button can be added.
Visit the preview URL for this PR (updated for commit ad11303): https://fan-square--pr633-hotfix-song-card-pri-dukgxprx.web.app (expires Thu, 20 Jun 2024 21:59:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b38f4676e459f355dcb11c95730012d43389bfd2 |
Visit the preview URL for this PR (updated for commit ad11303): https://newm-artist-portal--pr633-hotfix-song-card-pri-9rsiw6oe.web.app (expires Thu, 20 Jun 2024 21:59:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ec3483d4c62309afc398865bfd6a9fc9e03e1d46 |
Visit the marketplace preview URL for this PR (updated for commit 6927a07): |
Visit the wallet preview URL for this PR (updated for commit 6927a07): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ItemSkeleton.tsx
, (which probably should be renamed to SaleSkeleton.tsx
) also doesn't match up to the new price layout.
const ItemSkeleton: FunctionComponent = () => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the price should actually still appear in the upper right corner for the actual item. I'll make a separate ticket to make that update, since that requirement wasn't clear when changing the way it appeared for the previews.
Noticed this through my review as well but not directly related, must have been a recent PR. Saw an error with the
newm-web/apps/marketplace/src/components/Sale.tsx Lines 19 to 26 in d53fb12
|
Resolved the import name conflict. |
Visit the wallet preview URL for this PR (updated for commit c47f6b2): |
Visit the marketplace preview URL for this PR (updated for commit c47f6b2): |