Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRKT-161: ensures numeric input values stored in formik as numbers #758

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

scandycuz
Copy link
Contributor

No description provided.

Copy link

nx-cloud bot commented Oct 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 106ac23. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

Visit the studio preview URL for this PR 🚀 : https://758.artist.preview.newm.io/

Copy link

Visit the tools preview URL for this PR (updated for commit 6ef20ac):
🚀 https://e5oh2pkcmdmzqvhs6n7taz2g240kullp.lambda-url.us-west-2.on.aws/

Copy link

Visit the wallet preview URL for this PR (updated for commit 6ef20ac):
🚀 https://3gy2l4lricuvqptj6fuq2k4bou0pxlfz.lambda-url.us-west-2.on.aws/

Copy link

Visit the marketplace preview URL for this PR (updated for commit 6ef20ac):
🚀 https://52f37umvazq7zcgid3wx6zbjcq0dqaaj.lambda-url.us-west-2.on.aws/

ref={ ref }
{ ...field }
{ ...props }
onChange={ handleChange }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an onchange is passed I believe this will override that. Do we have instances with an onchange/handle change we need to account for?

Copy link
Contributor Author

@scandycuz scandycuz Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be any use case where onChange would be passed to a Formik field. For inputs where an onChange prop is passed, the non-Formik component can be used.

@scandycuz scandycuz merged commit 01ae18f into master Oct 23, 2024
6 checks passed
@scandycuz scandycuz deleted the MRKT-161-format-numbers-with-commas branch October 23, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants