-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STUD-351: Add Launch Darkly and apply a maintenance mode to be activated on demand #790
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d60dfbb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Visit the studio preview URL for this PR 🚀 : https://790.artist.preview.newm.io/ |
Visit the tools preview URL for this PR (updated for commit bbbe127): |
Visit the wallet preview URL for this PR (updated for commit bbbe127): |
Visit the marketplace preview URL for this PR (updated for commit bbbe127): |
@@ -0,0 +1,42 @@ | |||
import { useEffect } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component is what adds the user information to LD once they log in, we can then use that info to target certain features by user
@@ -0,0 +1,40 @@ | |||
# Feature Flag Naming Conventions for LaunchDarkly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to start off this doc to try to follow a standard since we will be sharing the space with the rest of the NEWM platforms, feedback is welcomed as always.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@@ -1,56 +1,60 @@ | |||
html { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why git thinks this is a repath but this is the monorepo global.css to be used in every new app that gets created. you might be wondering, how did I come up with this.... GREAT question. I saw what we had in all of the apps and combined into 1, only what made sense. I moved some styles to app-specific spaces. I created a ticket to create a new package if needed. This was the easiest path I found.
@@ -0,0 +1,40 @@ | |||
# Feature Flag Naming Conventions for LaunchDarkly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* MRKT-200: Add calim earnings to marketplace * MRKT-200: Refactor studio to use the shared claim earnings components * MRKT-200: Remove unecessary dynamic imports for shared components
Visit the wallet preview URL for this PR (updated for commit e9f8e78): |
Visit the tools preview URL for this PR (updated for commit e9f8e78): |
Visit the marketplace preview URL for this PR (updated for commit e9f8e78): |
ff.mov