Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STUD-351: Add Launch Darkly and apply a maintenance mode to be activated on demand #790

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

escobarjonatan
Copy link
Contributor

ff.mov

@escobarjonatan escobarjonatan requested a review from a team as a code owner November 9, 2024 05:49
Copy link

nx-cloud bot commented Nov 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d60dfbb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

github-actions bot commented Nov 9, 2024

Visit the studio preview URL for this PR 🚀 : https://790.artist.preview.newm.io/

Copy link

github-actions bot commented Nov 9, 2024

Visit the tools preview URL for this PR (updated for commit bbbe127):
🚀 https://lzussgdtigkkueght7czl5zuxm0kbzqr.lambda-url.us-west-2.on.aws/

Copy link

github-actions bot commented Nov 9, 2024

Visit the wallet preview URL for this PR (updated for commit bbbe127):
🚀 https://vvyxqj65b2cvs6qzet3atm2wby0hwwik.lambda-url.us-west-2.on.aws/

Copy link

github-actions bot commented Nov 9, 2024

Visit the marketplace preview URL for this PR (updated for commit bbbe127):
🚀 https://evhxs6c6xrdplecrotru73sir40ftmos.lambda-url.us-west-2.on.aws/

@@ -0,0 +1,42 @@
import { useEffect } from "react";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is what adds the user information to LD once they log in, we can then use that info to target certain features by user

@@ -0,0 +1,40 @@
# Feature Flag Naming Conventions for LaunchDarkly
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to start off this doc to try to follow a standard since we will be sharing the space with the rest of the NEWM platforms, feedback is welcomed as always.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@@ -1,56 +1,60 @@
html {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why git thinks this is a repath but this is the monorepo global.css to be used in every new app that gets created. you might be wondering, how did I come up with this.... GREAT question. I saw what we had in all of the apps and combined into 1, only what made sense. I moved some styles to app-specific spaces. I created a ticket to create a new package if needed. This was the easiest path I found.

@@ -0,0 +1,40 @@
# Feature Flag Naming Conventions for LaunchDarkly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@cristhianescobar cristhianescobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

* MRKT-200: Add calim earnings to marketplace

* MRKT-200: Refactor studio to use the shared claim earnings components

* MRKT-200: Remove unecessary dynamic imports for shared components
@escobarjonatan escobarjonatan merged commit c6863bc into master Nov 11, 2024
6 checks passed
@escobarjonatan escobarjonatan deleted the STUD-351-add-maintenance-mode branch November 11, 2024 22:53
Copy link

Visit the wallet preview URL for this PR (updated for commit e9f8e78):
🚀 https://vvyxqj65b2cvs6qzet3atm2wby0hwwik.lambda-url.us-west-2.on.aws/

Copy link

Visit the tools preview URL for this PR (updated for commit e9f8e78):
🚀 https://lzussgdtigkkueght7czl5zuxm0kbzqr.lambda-url.us-west-2.on.aws/

Copy link

Visit the marketplace preview URL for this PR (updated for commit e9f8e78):
🚀 https://evhxs6c6xrdplecrotru73sir40ftmos.lambda-url.us-west-2.on.aws/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants