STUD-381: Add feature flag to disable song minting and distribution #831
Conversation
escobarjonatan
commented
Nov 21, 2024
•
escobarjonatan
commented
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8635703. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Visit the studio preview URL for this PR 🚀 : https://831.artist.preview.newm.io/ |
|
Visit the tools preview URL for this PR (updated for commit 7e37089): |
|
Visit the wallet preview URL for this PR (updated for commit 7e37089): |
|
Visit the marketplace preview URL for this PR (updated for commit 7e37089): |
There was a problem hiding this comment.
It looks like the Switch element is supposed to change to grey/opacity to .7 when disabled, but I'm not sure if we want to also engage disabled view for the icon. Still shows as a white circle when disabled currently.
Could open a new ticket for this one, won't block this PR on account to this.
newm-web/packages/elements/src/lib/Switch.tsx
Lines 30 to 35 in c9dfd65
There was a problem hiding this comment.
yea this can be its own ticket
| toggleTooltipText={ | ||
| webStudioDisableTrackDistributionAndMinting | ||
| ? "Track distribution and minting is temporarily disabled. " + | ||
| "Please upload your song to save your progress, and check " + | ||
| "back later to finish the distribution process." | ||
| : undefined | ||
| } |
There was a problem hiding this comment.
This shows up in the Library edit song page when the minting is already toggled by default, I'm able to even proceed to next, logic needs to be added to disable this route as well.
There was a problem hiding this comment.
good catch, fixed it
There was a problem hiding this comment.
Fix looks good. We will need to make it more obvious though, first instinct isn't to go over to minting toggle to check for tooltip as the reason Next button is disabled, might confuse users.
There was a problem hiding this comment.
We can wait on feedback for this as it should just be in for a short(hopefully) period of time
|
Visit the wallet preview URL for this PR (updated for commit 5ea93d1): |
|
Visit the tools preview URL for this PR (updated for commit 5ea93d1): |
|
Visit the marketplace preview URL for this PR (updated for commit 5ea93d1): |
| toggleTooltipText={ | ||
| webStudioDisableTrackDistributionAndMinting | ||
| ? "Track distribution and minting is temporarily disabled. " + | ||
| "Please upload your song to save your progress, and check " + | ||
| "back later to finish the distribution process." | ||
| : undefined | ||
| } |
There was a problem hiding this comment.
Fix looks good. We will need to make it more obvious though, first instinct isn't to go over to minting toggle to check for tooltip as the reason Next button is disabled, might confuse users.
|
💀 wallet preview environment destroyed |
|
💀 tools preview environment destroyed |
|
💀 marketplace preview environment destroyed |
