This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Adapt the 'rpm-ostree' test suite to continue on failure #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `rpm-ostree` test suite to use the 'continue on failure' model. Partially addresses projectatomic#375
This worked well on a pristine system, but I was getting tripped up when re-using a test sytsem. This cleans up some of the transient artifacts that can be generated by the compose. Additionally, I added a `wait_for` to make sure the HTTP server starts.
|
bot, retest this please |
1 similar comment
|
bot, retest this please |
We were seeing instances where variable values passed to `import_role` where not being respected each time it was called. I thought that each time an 'import' was done the changed variables would be respected, but that doesn't appear to be the case. Using `include_role` will allow us to dynamically load in variables each time the role is used. This is kind of troubling as we made a large switch to using `include_role` in most places, but we've not run into any problems like this yet.
This is a forward-port of functionality from projectatomic#405 which corrects an assumption about how Ansible was handling failures.
mike-nguyen
reviewed
Jun 1, 2018
tests/rpm-ostree/deploy_version.yml
Outdated
| - name: Run ostree admin status as a quick sanity check | ||
| command: ostree admin status | ||
| tags: | ||
| - ostree_admin_status |
There was a problem hiding this comment.
Can this be moved into a separate test?
There was a problem hiding this comment.
Probably a good candidate for the sanity test
|
Oof...that was a lazy commit. Trying to use a task among the Working on a fix... |
In projectatomic#381, a sanity check for `ostree admin status` was added to the `rpm-ostree` test suite. It is probably better suited to the 'sanity' test suite so we are able to catch any regressions earlier in the testing cycle. I created a dumb role for the `ostree admin status` command since that was easier than trying to wedge it into an existing role.
miabbott
force-pushed
the
rpm_ostree_cont_on_fail
branch
from
928e83e to
0da3cb7
Compare
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the
rpm-ostreetest suite to the continue on failure model. As part of the work, I made some slight changes to the 'compose' portion of the test suite to make it a bit more resilient.Additionally, I snuck in a change to the
.gitignorefile to ignore the.logfiles that are being generated.Partially addresses #375