Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Related section at component level #1491

Closed
wants to merge 1 commit into from
Closed

Conversation

marlo-longley
Copy link
Contributor

@marlo-longley marlo-longley commented Dec 14, 2023

Closes #1464

To be honest, I don't understand why it was necessary to add a whole new ViewComponent to achieve this. I had to follow the exact pattern that already existed for AccessComponent to get this to display as its own section at the (EAD) component level. Initially I was able display it as part of the upper metadata with much less code, but I wanted it to look similar to the top collection level display, which puts "Related" as its own section.

Open to feedback on doing this in a simpler way! If this seems like the right approach, I can add some tests as well.

Here is the result of this in the UI
Screenshot 2023-12-14 at 3 44 56 PM

@seanaery
Copy link
Contributor

@marlo-longley That is an interesting approach and it certainly works. It does add some complexity that is probably not needed. The approach in arclight to date for component metadata has typically been to just put it all in one common bucket for display rather than try to segment it out into grouped sections.

This differs from the segmented collection metadata approach, but for good reason. Collections in EAD are often quite loaded with metadata, and the collection nav includes useful links to get to the different sections.

By contrast, components in EAD are in practice often only sparsely described. Though EAD permits you to have a lot of description on the component level, from what I have seen, the most common thing is a component will likely only have 1-3 total fields that'd get rendered in its metadata section.

@marlo-longley
Copy link
Contributor Author

@seanaery I would love not to add this to the repo haha. Thank you. I guess my assumption that it needed to look like the collection-level UI was incorrect.

@marlo-longley
Copy link
Contributor Author

@seanaery -- I will just add these as component_field as I think you are suggesting. I'll close this and open a new PR.

@seanaery
Copy link
Contributor

Sounds great -- thank you! Yep, I think we can simply add these right alongside all the existing config.add_component_field fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display <relatedmaterial> <originalsloc> and <separatedmaterial> at component level
2 participants