perf(*): replace encoding/json w/ sonic

Signed-off-by: Dwi Siswanto <[email protected]>

cmd/docgen/docgen.go

@@ -2,13 +2,13 @@ package main
 
 import (
 	"bytes"
-	"encoding/json"
 	"log"
 	"os"
 	"reflect"
 	"regexp"
 	"strings"
 
+	"github.com/bytedance/sonic"
 	"github.com/invopop/jsonschema"
 
 	"github.com/projectdiscovery/nuclei/v3/pkg/templates"
@@ -43,7 +43,7 @@ func main() {
 	jsonschemaData := r.Reflect(&templates.Template{})
 
 	var buf bytes.Buffer
-	encoder := json.NewEncoder(&buf)
+	encoder := sonic.ConfigStd.NewEncoder(&buf)
 	encoder.SetIndent("", "  ")
 	_ = encoder.Encode(jsonschemaData)
 

cmd/integration-test/fuzz.go

@@ -1,12 +1,12 @@
 package main
 
 import (
-	"encoding/json"
 	"fmt"
 	"net/http"
 	"net/http/httptest"
 	"net/url"
 
+	"github.com/bytedance/sonic"
 	"github.com/julienschmidt/httprouter"
 	"github.com/projectdiscovery/nuclei/v3/pkg/output"
 	"github.com/projectdiscovery/nuclei/v3/pkg/testutils"
@@ -87,7 +87,7 @@ func (h *fuzzModeOverride) Execute(filePath string) error {
 		return err
 	}
 	var event output.ResultEvent
-	err = json.Unmarshal([]byte(results[0]), &event)
+	err = sonic.Unmarshal([]byte(results[0]), &event)
 	if err != nil {
 		return fmt.Errorf("could not unmarshal event: %s", err)
 	}
@@ -132,7 +132,7 @@ func (h *fuzzTypeOverride) Execute(filePath string) error {
 		return err
 	}
 	var event output.ResultEvent
-	err = json.Unmarshal([]byte(results[0]), &event)
+	err = sonic.Unmarshal([]byte(results[0]), &event)
 	if err != nil {
 		return fmt.Errorf("could not unmarshal event: %s", err)
 	}
@@ -200,4 +200,4 @@ func (h *fuzzMultipleMode) Execute(filePath string) error {
 		return err
 	}
 	return expectResultsCount(got, 1)
-}
+}

cmd/integration-test/http.go

@@ -1,7 +1,6 @@
 package main
 
 import (
-	"encoding/json"
 	"errors"
 	"fmt"
 	"net/http"
@@ -14,6 +13,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/bytedance/sonic"
 	"github.com/julienschmidt/httprouter"
 	"gopkg.in/yaml.v2"
 
@@ -480,7 +480,7 @@ func (h *httpPostJSONBody) Execute(filePath string) error {
 			Password string `json:"password"`
 		}
 		obj := &doc{}
-		if err := json.NewDecoder(r.Body).Decode(obj); err != nil {
+		if err := sonic.ConfigStd.NewDecoder(r.Body).Decode(obj); err != nil {
 			routerErr = err
 			return
 		}

cmd/integration-test/matcher-status.go

@@ -1,10 +1,10 @@
 package main
 
 import (
-	"encoding/json"
 	"fmt"
 	"strings"
 
+	"github.com/bytedance/sonic"
 	"github.com/projectdiscovery/nuclei/v3/pkg/output"
 	"github.com/projectdiscovery/nuclei/v3/pkg/testutils"
 )
@@ -26,7 +26,7 @@ func (h *httpNoAccess) Execute(filePath string) error {
 		return err
 	}
 	event := &output.ResultEvent{}
-	_ = json.Unmarshal([]byte(results[0]), event)
+	_ = sonic.Unmarshal([]byte(results[0]), event)
 	expectedError := "no address found for host"
 	if !strings.Contains(event.Error, expectedError) {
 		return fmt.Errorf("unexpected result: expecting \"%s\" error but got \"%s\"", expectedError, event.Error)
@@ -43,7 +43,7 @@ func (h *networkNoAccess) Execute(filePath string) error {
 		return err
 	}
 	event := &output.ResultEvent{}
-	_ = json.Unmarshal([]byte(results[0]), event)
+	_ = sonic.Unmarshal([]byte(results[0]), event)
 
 	if event.Error != "no address found for host" {
 		return fmt.Errorf("unexpected result: expecting \"no address found for host\" error but got \"%s\"", event.Error)
@@ -60,7 +60,7 @@ func (h *headlessNoAccess) Execute(filePath string) error {
 		return err
 	}
 	event := &output.ResultEvent{}
-	_ = json.Unmarshal([]byte(results[0]), event)
+	_ = sonic.Unmarshal([]byte(results[0]), event)
 
 	if event.Error == "" {
 		return fmt.Errorf("unexpected result: expecting an error but got \"%s\"", event.Error)
@@ -77,7 +77,7 @@ func (h *javascriptNoAccess) Execute(filePath string) error {
 		return err
 	}
 	event := &output.ResultEvent{}
-	_ = json.Unmarshal([]byte(results[0]), event)
+	_ = sonic.Unmarshal([]byte(results[0]), event)
 
 	if event.Error == "" {
 		return fmt.Errorf("unexpected result: expecting an error but got \"%s\"", event.Error)
@@ -94,7 +94,7 @@ func (h *websocketNoAccess) Execute(filePath string) error {
 		return err
 	}
 	event := &output.ResultEvent{}
-	_ = json.Unmarshal([]byte(results[0]), event)
+	_ = sonic.Unmarshal([]byte(results[0]), event)
 
 	if event.Error == "" {
 		return fmt.Errorf("unexpected result: expecting an error but got \"%s\"", event.Error)
@@ -111,7 +111,7 @@ func (h *dnsNoAccess) Execute(filePath string) error {
 		return err
 	}
 	event := &output.ResultEvent{}
-	_ = json.Unmarshal([]byte(results[0]), event)
+	_ = sonic.Unmarshal([]byte(results[0]), event)
 
 	if event.Error == "" {
 		return fmt.Errorf("unexpected result: expecting an error but got \"%s\"", event.Error)

cmd/tmc/main.go

@@ -2,7 +2,6 @@ package main
 
 import (
 	"bytes"
-	"encoding/json"
 	"fmt"
 	"log"
 	"os"
@@ -12,6 +11,7 @@ import (
 	"sort"
 	"strings"
 
+	"github.com/bytedance/sonic"
 	"github.com/projectdiscovery/goflags"
 	"github.com/projectdiscovery/gologger"
 	"github.com/projectdiscovery/gologger/levels"
@@ -243,7 +243,7 @@ func enhanceTemplate(data string) (string, bool, error) {
 		return data, false, errorutil.New("unexpected status code: %v", resp.Status)
 	}
 	var templateResp TemplateResp
-	if err := json.NewDecoder(resp.Body).Decode(&templateResp); err != nil {
+	if err := sonic.ConfigStd.NewDecoder(resp.Body).Decode(&templateResp); err != nil {
 		return data, false, err
 	}
 	if strings.TrimSpace(templateResp.Enhanced) != "" {
@@ -277,7 +277,7 @@ func formatTemplate(data string) (string, bool, error) {
 		return data, false, errorutil.New("unexpected status code: %v", resp.Status)
 	}
 	var templateResp TemplateResp
-	if err := json.NewDecoder(resp.Body).Decode(&templateResp); err != nil {
+	if err := sonic.ConfigStd.NewDecoder(resp.Body).Decode(&templateResp); err != nil {
 		return data, false, err
 	}
 	if strings.TrimSpace(templateResp.Updated) != "" {
@@ -311,7 +311,7 @@ func lintTemplate(data string) (bool, error) {
 		return false, errorutil.New("unexpected status code: %v", resp.Status)
 	}
 	var lintResp TemplateLintResp
-	if err := json.NewDecoder(resp.Body).Decode(&lintResp); err != nil {
+	if err := sonic.ConfigStd.NewDecoder(resp.Body).Decode(&lintResp); err != nil {
 		return false, err
 	}
 	if lintResp.Lint {
@@ -333,7 +333,7 @@ func validateTemplate(data string) (bool, error) {
 		return false, errorutil.New("unexpected status code: %v", resp.Status)
 	}
 	var validateResp TemplateResp
-	if err := json.NewDecoder(resp.Body).Decode(&validateResp); err != nil {
+	if err := sonic.ConfigStd.NewDecoder(resp.Body).Decode(&validateResp); err != nil {
 		return false, err
 	}
 	if validateResp.Validate {

go.mod

@@ -138,7 +138,8 @@ require (
 	github.com/bodgit/sevenzip v1.6.0 // indirect
 	github.com/bodgit/windows v1.0.1 // indirect
 	github.com/buger/jsonparser v1.1.1 // indirect
-	github.com/bytedance/sonic v1.9.1 // indirect
+	github.com/bytedance/sonic v1.12.8 // indirect
+	github.com/bytedance/sonic/loader v0.2.2 // indirect
 	github.com/cenkalti/backoff/v4 v4.2.1 // indirect
 	github.com/cespare/xxhash/v2 v2.2.0 // indirect
 	github.com/charmbracelet/lipgloss v0.13.0 // indirect
@@ -147,6 +148,7 @@ require (
 	github.com/chenzhuoyu/base64x v0.0.0-20221115062448-fe3a3abad311 // indirect
 	github.com/cloudflare/cfssl v1.6.4 // indirect
 	github.com/cloudflare/circl v1.3.8 // indirect
+	github.com/cloudwego/base64x v0.1.5 // indirect
 	github.com/containerd/continuity v0.4.2 // indirect
 	github.com/cyphar/filepath-securejoin v0.2.5 // indirect
 	github.com/davidmz/go-pageant v1.0.2 // indirect

go.sum

@@ -219,6 +219,11 @@ github.com/bwesterb/go-ristretto v1.2.0/go.mod h1:fUIoIZaG73pV5biE2Blr2xEzDoMj7N
 github.com/bytedance/sonic v1.5.0/go.mod h1:ED5hyg4y6t3/9Ku1R6dU/4KyJ48DZ4jPhfY1O2AihPM=
 github.com/bytedance/sonic v1.9.1 h1:6iJ6NqdoxCDr6mbY8h18oSO+cShGSMRGCEo7F2h0x8s=
 github.com/bytedance/sonic v1.9.1/go.mod h1:i736AoUSYt75HyZLoJW9ERYxcy6eaN6h4BZXU064P/U=
+github.com/bytedance/sonic v1.12.8 h1:4xYRVRlXIgvSZ4e8iVTlMF5szgpXd4AfvuWgA8I8lgs=
+github.com/bytedance/sonic v1.12.8/go.mod h1:uVvFidNmlt9+wa31S1urfwwthTWteBgG0hWuoKAXTx8=
+github.com/bytedance/sonic/loader v0.1.1/go.mod h1:ncP89zfokxS5LZrJxl5z0UJcsk4M4yY2JpfqGeCtNLU=
+github.com/bytedance/sonic/loader v0.2.2 h1:jxAJuN9fOot/cyz5Q6dUuMJF5OqQ6+5GfA8FjjQ0R4o=
+github.com/bytedance/sonic/loader v0.2.2/go.mod h1:N8A3vUdtUebEY2/VQC0MyhYeKUFosQU6FxH2JmUe6VI=
 github.com/caddyserver/certmagic v0.19.2 h1:HZd1AKLx4592MalEGQS39DKs2ZOAJCEM/xYPMQ2/ui0=
 github.com/caddyserver/certmagic v0.19.2/go.mod h1:fsL01NomQ6N+kE2j37ZCnig2MFosG+MIO4ztnmG/zz8=
 github.com/casbin/casbin/v2 v2.1.2/go.mod h1:YcPU1XXisHhLzuxH9coDNf2FbKpjGlbCg3n9yuLkIJQ=
@@ -266,6 +271,9 @@ github.com/cloudflare/cfssl v1.6.4/go.mod h1:8b3CQMxfWPAeom3zBnGJ6sd+G1NkL5TXqmD
 github.com/cloudflare/circl v1.1.0/go.mod h1:prBCrKB9DV4poKZY1l9zBXg2QJY7mvgRvtMxxK7fi4I=
 github.com/cloudflare/circl v1.3.8 h1:j+V8jJt09PoeMFIu2uh5JUyEaIHTXVOHslFoLNAKqwI=
 github.com/cloudflare/circl v1.3.8/go.mod h1:PDRU+oXvdD7KCtgKxW95M5Z8BpSCJXQORiZFnBQS5QU=
+github.com/cloudwego/base64x v0.1.5 h1:XPciSp1xaq2VCSt6lF0phncD4koWyULpl5bUxbfCyP4=
+github.com/cloudwego/base64x v0.1.5/go.mod h1:0zlkT4Wn5C6NdauXdJRhSKRlJvmclQ1hhJgA0rcu/8w=
+github.com/cloudwego/iasm v0.2.0/go.mod h1:8rXZaNYT2n95jn+zTI1sDr+IgcD2GVs0nlbbQPiEFhY=
 github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
 github.com/cnf/structhash v0.0.0-20201127153200-e1b16c1ebc08 h1:ox2F0PSMlrAAiAdknSRMDrAr8mfxPCfSZolH+/qQnyQ=
 github.com/cnf/structhash v0.0.0-20201127153200-e1b16c1ebc08/go.mod h1:pCxVEbcm3AMg7ejXyorUXi6HQCzOIBf7zEDVPtw0/U4=
@@ -675,6 +683,7 @@ github.com/klauspost/cpuid/v2 v2.2.5/go.mod h1:Lcz8mBdAVJIBVzewtcLocK12l3Y+JytZY
 github.com/klauspost/pgzip v1.2.5/go.mod h1:Ch1tH69qFZu15pkjo5kYi6mth2Zzwzt50oCQKQE9RUs=
 github.com/klauspost/pgzip v1.2.6 h1:8RXeL5crjEUFnR2/Sn6GJNWtSQ3Dk8pq4CL3jvdDyjU=
 github.com/klauspost/pgzip v1.2.6/go.mod h1:Ch1tH69qFZu15pkjo5kYi6mth2Zzwzt50oCQKQE9RUs=
+github.com/knz/go-libedit v1.10.1/go.mod h1:MZTVkCWyz0oBc7JOWP3wNAzd002ZbM/5hgShxwh4x8M=
 github.com/konsorten/go-windows-terminal-sequences v1.0.1/go.mod h1:T0+1ngSBFLxvqU3pZ+m/2kptfBszLMUkC4ZK/EgS/cQ=
 github.com/konsorten/go-windows-terminal-sequences v1.0.3/go.mod h1:T0+1ngSBFLxvqU3pZ+m/2kptfBszLMUkC4ZK/EgS/cQ=
 github.com/kr/logfmt v0.0.0-20140226030751-b84e30acd515/go.mod h1:+0opPa2QZZtGFBFZlji/RkVcI2GknAs/DXo4wKdlNEc=
@@ -1677,6 +1686,7 @@ mellium.im/sasl v0.3.1 h1:wE0LW6g7U83vhvxjC1IY8DnXM+EU095yeo8XClvCdfo=
 mellium.im/sasl v0.3.1/go.mod h1:xm59PUYpZHhgQ9ZqoJ5QaCqzWMi8IeS49dhp6plPCzw=
 moul.io/http2curl v1.0.0 h1:6XwpyZOYsgZJrU8exnG87ncVkU1FVCcTRpwzOkTDUi8=
 moul.io/http2curl v1.0.0/go.mod h1:f6cULg+e4Md/oW1cYmwW4IWQOVl2lGbmCNGOHvzX2kE=
+nullprogram.com/x/optparse v1.0.0/go.mod h1:KdyPE+Igbe0jQUrVfMqDMeJQIJZEuyV7pjYmp6pbG50=
 rsc.io/binaryregexp v0.2.0/go.mod h1:qTv7/COck+e2FymRvadv62gMdZztPaShugOCi3I+8D8=
 rsc.io/pdf v0.1.1/go.mod h1:n8OzWcQ6Sp37PL01nO98y4iUCRdTGarVfzxY20ICaU4=
 rsc.io/quote/v3 v3.1.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=

internal/httpapi/apiendpoint.go

@@ -1,10 +1,10 @@
 package httpapi
 
 import (
-	"encoding/json"
 	"net/http"
 	"time"
 
+	"github.com/bytedance/sonic"
 	"github.com/projectdiscovery/nuclei/v3/pkg/js/compiler"
 	"github.com/projectdiscovery/nuclei/v3/pkg/types"
 )
@@ -66,7 +66,7 @@ func (s *Server) getSettings(w http.ResponseWriter, _ *http.Request) {
 		JavascriptConcurrency: compiler.PoolingJsVmConcurrency,
 	}
 	w.Header().Set("Content-Type", "application/json")
-	if err := json.NewEncoder(w).Encode(concurrencySettings); err != nil {
+	if err := sonic.ConfigStd.NewEncoder(w).Encode(concurrencySettings); err != nil {
 		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
@@ -75,7 +75,7 @@ func (s *Server) getSettings(w http.ResponseWriter, _ *http.Request) {
 // UpdateSettings handles PUT requests to update the concurrency settings
 func (s *Server) updateSettings(w http.ResponseWriter, r *http.Request) {
 	var newSettings Concurrency
-	if err := json.NewDecoder(r.Body).Decode(&newSettings); err != nil {
+	if err := sonic.ConfigStd.NewDecoder(r.Body).Decode(&newSettings); err != nil {
 		http.Error(w, err.Error(), http.StatusBadRequest)
 		return
 	}

internal/pdcp/writer.go

@@ -4,7 +4,6 @@ import (
 	"bufio"
 	"bytes"
 	"context"
-	"encoding/json"
 	"fmt"
 	"io"
 	"net/http"
@@ -13,6 +12,7 @@ import (
 	"sync/atomic"
 	"time"
 
+	"github.com/bytedance/sonic"
 	"github.com/projectdiscovery/gologger"
 	"github.com/projectdiscovery/nuclei/v3/pkg/catalog/config"
 	"github.com/projectdiscovery/nuclei/v3/pkg/output"
@@ -222,7 +222,7 @@ func (u *UploadWriter) upload(data []byte) error {
 		return fmt.Errorf("could not upload results got status code %v on %v", resp.StatusCode, resp.Request.URL.String())
 	}
 	var uploadResp uploadResponse
-	if err := json.Unmarshal(bin, &uploadResp); err != nil {
+	if err := sonic.Unmarshal(bin, &uploadResp); err != nil {
 		return errorutil.NewWithErr(err).Msgf("could not unmarshal response got %v", string(bin))
 	}
 	if uploadResp.ID != "" && u.scanID == "" {

internal/runner/runner.go

@@ -2,7 +2,6 @@ package runner
 
 import (
 	"context"
-	"encoding/json"
 	"fmt"
 	"net/http"
 	_ "net/http/pprof"
@@ -13,6 +12,7 @@ import (
 	"sync/atomic"
 	"time"
 
+	"github.com/bytedance/sonic"
 	"github.com/projectdiscovery/nuclei/v3/internal/pdcp"
 	"github.com/projectdiscovery/nuclei/v3/pkg/authprovider"
 	"github.com/projectdiscovery/nuclei/v3/pkg/fuzz/frequency"
@@ -288,7 +288,7 @@ func New(options *types.Options) (*Runner, error) {
 		if err != nil {
 			return nil, err
 		}
-		err = json.Unmarshal(file, &resumeCfg)
+		err = sonic.Unmarshal(file, &resumeCfg)
 		if err != nil {
 			return nil, err
 		}
@@ -795,7 +795,7 @@ func (r *Runner) SaveResumeConfig(path string) error {
 	}
 	resumeCfgClone := r.resumeCfg.Clone()
 	resumeCfgClone.ResumeFrom = resumeCfgClone.Current
-	data, _ := json.MarshalIndent(resumeCfgClone, "", "\t")
+	data, _ := sonic.MarshalIndent(resumeCfgClone, "", "\t")
 
 	return os.WriteFile(path, data, permissionutil.ConfigFilePermission)
 }
@@ -830,7 +830,7 @@ func UploadResultsToCloud(options *types.Options) error {
 	defer file.Close()
 
 	gologger.Info().Msgf("Uploading scan results to cloud dashboard from %s", options.ScanUploadFile)
-	dec := json.NewDecoder(file)
+	dec := sonic.ConfigStd.NewDecoder(file)
 	for dec.More() {
 		var r output.ResultEvent
 		err := dec.Decode(&r)

pkg/authprovider/authx/dynamic.go

@@ -6,6 +6,7 @@ import (
 	"strings"
 	"sync"
 
+	"github.com/bytedance/sonic"
 	"github.com/projectdiscovery/gologger"
 	"github.com/projectdiscovery/nuclei/v3/pkg/protocols/common/replacer"
 	errorutil "github.com/projectdiscovery/utils/errors"
@@ -34,11 +35,11 @@ type Dynamic struct {
 }
 
 func (d *Dynamic) UnmarshalJSON(data []byte) error {
-	if err := json.Unmarshal(data, &d); err != nil {
+	if err := sonic.Unmarshal(data, &d); err != nil {
 		return err
 	}
 	var s Secret
-	if err := json.Unmarshal(data, &s); err != nil {
+	if err := sonic.Unmarshal(data, &s); err != nil {
 		return err
 	}
 	d.Secret = s