Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanup and comments in confirm-vote #1

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Some cleanup and comments in confirm-vote #1

merged 1 commit into from
Jul 31, 2024

Conversation

shamsasari
Copy link
Contributor

No description provided.

@shamsasari shamsasari requested a review from shibatales July 31, 2024 13:37
@shamsasari
Copy link
Contributor Author

shamsasari commented Jul 31, 2024 •
edited
Loading

This is dependent on projectglove/glove-monorepo#30 being deployed, as that PR supports the hex strings beginning with 0x and the use of u8aToHex produces 0x at the beginning.

Also, I can confirm the service successfully processes the vote request and returns a HTTP 200. However, for some reason the frontend complains of a 500 internal error. Perhaps something to do with the proxy?

shibatales
shibatales approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@shibatales shibatales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shamsasari shamsasari merged commit cb0864b into main Jul 31, 2024
@shamsasari shamsasari deleted the shams-vote-cleanup branch July 31, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shibatales shibatales shibatales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamsasari @shibatales