Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glove mixing only once near the end of the poll #24

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

shamsasari
Copy link
Contributor

@shamsasari shamsasari commented Jul 25, 2024

The service will mix votes only once when one of the following conditions are met:

  • Near the end of the poll's decision period, regardless of whether it is confirming or not.
  • Near the end of the confirmation period if confirmation will end within the decision period.

Explanation of these are in the README. "Near" is defined as 160 blocks, which equates to 15 mins assuming a block time of 6 seconds.

Vote requests and remove vote requests are rejected once votes have been mixed. A re-mix will only occur if the service detects one of the Glove participants voting outside of Glove. All of this is checked (and acted upon) once every 60 seconds on the background thread.

The previous behaviour of mixing regularly, which is necessary for development and testing purposes, has been preserved behind a --regular-mix flag. The test environment has this enabled.

@shamsasari shamsasari force-pushed the shams-confirmation-mixing branch 4 times, most recently from bf2c03d to 22004f4 Compare July 25, 2024 17:47
@shamsasari shamsasari requested a review from noah-foltz July 25, 2024 17:51
@shamsasari shamsasari changed the title Glove mixing now occurring only once near the end of a poll Glove mixing only once near the end of the poll Jul 25, 2024
@shamsasari shamsasari force-pushed the shams-confirmation-mixing branch from 22004f4 to 7b1c483 Compare July 26, 2024 11:58
@shamsasari shamsasari merged commit ee98280 into main Jul 26, 2024
1 check passed
@shamsasari shamsasari deleted the shams-confirmation-mixing branch July 26, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants