Start release v0.26.0 #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If extraLabels or extraAnnotations are defined, always set this.
Following ClusterProfile
```yaml
apiVersion: config.projectsveltos.io/v1alpha1
kind: ClusterProfile
metadata:
labels:
version: 1.0.0
name: kyverno
spec:
clusterSelector: env=fv
syncMode: ContinuousWithDriftDetection
extraLabels:
version: 1.0.0
field: extraLabels
extraAnnotations:
version: 1.0.0
field: extraAnnotations
helmCharts:
- repositoryURL: https://kyverno.github.io/kyverno/
repositoryName: kyverno
chartName: kyverno/kyverno
chartVersion: v3.1.1
releaseName: kyverno-latest
releaseNamespace: kyverno
helmChartAction: Install
values: |
customLabels:
version: 1.0.0
field: customLabels
```
has extraLabels overriding a label set by helm chart itself.
If we don't always try to set extraLabels and extraAnnotations following scenario
would be broken:
1. deploy clusterProfile => all kyverno resources have label __field: extraLabels__
2. modify a resource directly in the managed cluster => this will cause a reconcilation (configuration drift detected)
3. helm set label __field: customLabels__.
Previoulsy code would not reset label __field: extraLabels__ because nothing had changed in extraLabels configuration.
This PR fixes that by always setting extraLabels and extraAnnotations irrespective of what happened in previous
reconciliations.
Merge dev to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.