Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NET 9.0 #280

Closed
wants to merge 26 commits into from
Closed

Update to NET 9.0 #280

wants to merge 26 commits into from

Conversation

vdboots
Copy link

@vdboots vdboots commented Feb 2, 2025

User description

Update to NET 9.0


PR Type

Enhancement, Bug fix, Tests, Documentation


Description

  • Upgraded project to .NET 9.0, including all dependencies and target frameworks.

  • Replaced GeneratedRegex with RegexOptions.Compiled for performance improvements.

  • Updated GitHub Actions workflows to use newer versions of actions.

  • Enhanced documentation with updated links and installation instructions.

  • Added missing using directives to test files for better clarity and functionality.


Changes walkthrough 📝

Relevant files
Enhancement
10 files
JsonExpressionProcessor.cs
Replaced `GeneratedRegex` with `RegexOptions.Compiled`     
+3/-5     
KubeCtlService.cs
Replaced `GeneratedRegex` with `RegexOptions.Compiled`     
+3/-4     
Aspirate.Cli.csproj
Upgraded to .NET 9.0 and updated metadata                               
+9/-6     
Aspirate.Commands.csproj
Upgraded to .NET 9.0                                                                         
+1/-1     
Aspirate.Processors.csproj
Upgraded to .NET 9.0                                                                         
+1/-1     
Aspirate.Secrets.csproj
Upgraded to .NET 9.0                                                                         
+1/-1     
Aspirate.Services.csproj
Upgraded to .NET 9.0                                                                         
+1/-1     
Aspirate.Shared.csproj
Upgraded to .NET 9.0                                                                         
+1/-1     
Aspirate.Tests.csproj
Upgraded to .NET 9.0                                                                         
+1/-1     
TestApp.csproj
Upgraded to .NET 9.0                                                                         
+1/-1     
Formatting
1 files
ContainerCompositionService.cs
Removed unnecessary blank line                                                     
+0/-1     
Bug fix
1 files
ComposeExtensions.cs
Added missing `using` directive                                                   
+2/-0     
Documentation
4 files
IShellExecutionService.cs
Updated XML documentation for clarity                                       
+1/-1     
README.md
Updated documentation links and installation instructions
+8/-6     
Getting-Started.md
Updated video link in documentation                                           
+1/-1     
Installing-as-a-Global-Tool.md
Updated installation instructions for new package ID         
+2/-2     
Configuration changes
4 files
AspireLiterals.cs
Updated default dashboard image to version 9.0                     
+1/-1     
docs.yaml
Updated GitHub Actions to newer versions                                 
+6/-6     
main.yaml
Updated .NET version to 9.0 in workflow                                   
+1/-1     
pull-requests.yaml
Updated .NET version to 9.0 in workflow                                   
+1/-1     
Tests
2 files
ActionExecutorTests.cs
Added missing `using` directives                                                 
+4/-0     
BaseActionTests.cs
Added missing `using` directive                                                   
+2/-0     
Dependencies
1 files
Directory.Packages.props
Updated package dependencies to latest versions                   
+11/-11 
Additional files
24 files
InitializeConfigurationActionTests.cs +3/-0     
LoadConfigurationActionTests.cs +2/-0     
PopulateContainerDetailsForProjectsActionTests.cs +5/-0     
ApplyManifestsToClusterActionTests.cs +4/-0     
GenerateAspireManifestActionTests.cs +5/-0     
GenerateDockerComposeManifestActionTests.cs +2/-0     
GenerateKustomizeManifestsActionTests.cs +2/-0     
LoadAspireManifestActionTests.cs +5/-0     
RemoveManifestsToClusterActionTests.cs +4/-0     
PopulateInputsActionTests.cs +4/-0     
SaveSecretsActionTests.cs +4/-0     
DockerComposeBuilderTests.cs +4/-0     
KubernetesDeploymentDataExtensionTests.cs +3/-1     
ContainerProcessorTests.cs +3/-0     
SecretProviderTests.cs +3/-0     
AspirateConfigurationServiceTest.cs +3/-0     
BaseServiceTests.cs +2/-0     
ContainerCompositionServiceTest.cs +6/-0     
ContainerDetailsServiceTests.cs +5/-0     
ContainerOptionsTests.cs +5/-0     
KubeCtlServiceTests.cs +3/-0     
ManifestFileParserServiceTests.cs +6/-0     
ProjectPropertyServiceTests.cs +3/-0     
SecretServiceTests.cs +2/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    qodo-merge-pro bot commented Feb 2, 2025

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Performance

    The new regex pattern compilation approach using RegexOptions.Compiled should be validated to ensure it provides the expected performance improvements over the previous GeneratedRegex implementation

    private static readonly Regex PlaceholderPatternRegex = new(@"{([\w.-]+)}", RegexOptions.Compiled);

    Copy link

    qodo-merge-pro bot commented Feb 2, 2025

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Fix regex pattern escaping

    The regex pattern should be compiled only once and reused. Consider making the
    regex pattern static readonly to improve performance and avoid recompilation on
    each use.

    src/Aspirate.Processors/Transformation/Json/JsonExpressionProcessor.cs [84]

    -private static readonly Regex PlaceholderPatternRegex = new(@"{([\w.-]+)}", RegexOptions.Compiled);
    +private static readonly Regex PlaceholderPatternRegex = new(@"\{([\w\.-]+)\}", RegexOptions.Compiled);
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: The suggestion correctly identifies a potential issue with regex pattern escaping. Properly escaped regex patterns are crucial for accurate string matching and prevent potential runtime errors. The improved code provides the correct escaping for curly braces and dots.

    8

    @vdboots vdboots closed this Feb 6, 2025
    @vdboots
    Copy link
    Author

    vdboots commented Feb 6, 2025

    wil be change to another flow

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant