bom should not include guava - it was only for internal code reuse (#…

…1269) fixes #1268 Signed-off-by: Gregor Zeitlinger <[email protected]>
prometheus · Jan 30, 2025 · 07e66ec · 07e66ec
1 parent 31c7b6b
commit 07e66ec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/pom.xml b/pom.xml
@@ -17,6 +17,7 @@
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <automatic.module.name>--module-name-need-to-be-overriden--</automatic.module.name>
+        <guava.version>33.4.0-jre</guava.version>
         <junit-jupiter.version>5.11.4</junit-jupiter.version>
         <otel.instrumentation.version>2.12.0-alpha</otel.instrumentation.version>
         <java.version>8</java.version>
@@ -82,16 +83,6 @@
         <module>prometheus-metrics-simpleclient-bridge</module>
     </modules>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>com.google.guava</groupId>
-                <artifactId>guava</artifactId>
-                <version>33.4.0-jre</version>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>com.google.code.findbugs</groupId>
@@ -128,6 +119,7 @@
         <dependency>
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>
+            <version>${guava.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>

diff --git a/prometheus-metrics-instrumentation-guava/pom.xml b/prometheus-metrics-instrumentation-guava/pom.xml
@@ -37,6 +37,7 @@
         <dependency>
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>
+            <version>${guava.version}</version>
             <scope>provided</scope>
         </dependency>
         <dependency>