Update shaded dependencies in BOM

Signed-off-by: Fabian Stäber <[email protected]>
prometheus · Mar 22, 2024 · fbb6ae7 · fbb6ae7
1 parent 71cf428
commit fbb6ae7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/MAINTAINER_NOTES.md b/MAINTAINER_NOTES.md
@@ -36,7 +36,11 @@ Step 3: Update `prometheus-metrics-exporter-opentelemetry`
 * Change the version of the `prometheus-metrics-shaded-opentelemetry` dependency in `pom.xml` to `${project.version}`.
 * Use find-and-replace to update the version numbers in the imported package names in the source code of `prometheus-metrics-exporter-opentelemetry`.
 
-Step 4: Release
+Step 4: Update `prometheus-metrics-bom`
+
+* Set the shaded dependency version property to `${project.version}` in `prometheus-metrics-bom/pom.xml`
+
+Step 5: Release
 
 _see below_
 
@@ -45,7 +49,7 @@ _see below_
 Create a commit to temporarily add shaded dependencies to the project:
 
 * Add the `prometheus-metrics-shaded-dependencies` module to the root `pom.xml`.
-* Change the versions of the shaded dependencies to `${project.version}` in `prometheus-metrics-exporter-opentelemetry` and `prometheus-metrics-exposition-formats`.
+* Change the versions of the shaded dependencies to `${project.version}` in `prometheus-metrics-exporter-opentelemetry`, `prometheus-metrics-exposition-formats`, and `prometheus-metrics-bom`.
 
 Release:
 
@@ -61,4 +65,4 @@ After that, manually verify the uploaded artifacts on [https://oss.sonatype.org/
 Create a commit to remove dependencies from the build (undoing the first step):
 
 * Comment out the `prometheus-metrics-shaded-dependencies` module to the root `pom.xml`.
-* Change the versions of the shaded dependencies to the latest released version on Maven Central in `prometheus-metrics-exporter-opentelemetry` and `prometheus-metrics-exposition-formats`.
+* Change the versions of the shaded dependencies to the latest released version on Maven Central in `prometheus-metrics-exporter-opentelemetry`, `prometheus-metrics-exposition-formats`, and `prometheus-metrics-bom`.
diff --git a/prometheus-metrics-bom/pom.xml b/prometheus-metrics-bom/pom.xml
@@ -118,17 +118,20 @@
             <dependency>
                 <groupId>io.prometheus</groupId>
                 <artifactId>prometheus-metrics-shaded-dependencies</artifactId>
-                <version>${prometheus.metrics.shaded.dependencies.version}</version>
+                <!-- <version>${prometheus.metrics.shaded.dependencies.version}</version> -->
+                <version>${project.version}</version>
             </dependency>
             <dependency>
                 <groupId>io.prometheus</groupId>
                 <artifactId>prometheus-metrics-shaded-protobuf</artifactId>
-                <version>${prometheus.metrics.shaded.dependencies.version}</version>
+                <!-- <version>${prometheus.metrics.shaded.dependencies.version}</version> -->
+                <version>${project.version}</version>
             </dependency>
             <dependency>
                 <groupId>io.prometheus</groupId>
                 <artifactId>prometheus-metrics-shaded-opentelemetry</artifactId>
-                <version>${prometheus.metrics.shaded.dependencies.version}</version>
+                <!-- <version>${prometheus.metrics.shaded.dependencies.version}</version> -->
+                <version>${project.version}</version>
             </dependency>
         </dependencies>
     </dependencyManagement>