Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups in instrumentation-jvm #1014

Closed

Conversation

mimaison
Copy link
Contributor

@mimaison mimaison commented Oct 1, 2024

Same as #1012, let's see if the build runs here

@mimaison
Copy link
Contributor Author

mimaison commented Oct 1, 2024

Here the build fails because of spotless issues in the prometheus-metrics-model module which this PR does not touch: https://github.com/mimaison/client_java/actions/runs/11127458358/job/30919802107

@mimaison
Copy link
Contributor Author

mimaison commented Oct 1, 2024

I wonder if we should apply spotless across the whole project at once, and then restart working on code changes.

@zeitlinger
Copy link
Member

Here the build fails because of spotless issues in the prometheus-metrics-model module which this PR does not touch: https://github.com/mimaison/client_java/actions/runs/11127458358/job/30919802107

problem seems to be that the action runs in your repo - where origin/main is different - that's why the build check here is not working

@zeitlinger
Copy link
Member

I wonder if we should apply spotless across the whole project at once, and then restart working on code changes.

wondering that too - makes it easier to review changes

Signed-off-by: Mickael Maison <[email protected]>
@mimaison mimaison force-pushed the cleanups-instrumentation-jvm-2 branch from 2a1f02a to ee36ad0 Compare October 1, 2024 14:48
@zeitlinger
Copy link
Member

I wonder if we should apply spotless across the whole project at once, and then restart working on code changes.

wondering that too - makes it easier to review changes

done - #1015

@mimaison
Copy link
Contributor Author

mimaison commented Oct 1, 2024

Awesome, let me rebase!

@mimaison
Copy link
Contributor Author

mimaison commented Oct 1, 2024

I'll close this PR and keep the original one #1012

@mimaison mimaison closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants