Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance]Use threadGroup to compute threads state rather than ThreadMXBean #1235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Performance]Use threadGroup to compute threads state rather than ThreadMXBean #1235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a6c2d3
[Performance]Use threadGroup to compute threads state rather than Thr…
Dec 18, 2024
7f3f1b6
remove unused method.
hfutatzhanghb Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 33 additions & 27 deletions ...tation-jvm/src/main/java/io/prometheus/metrics/instrumentation/jvm/JvmThreadsMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private void register(PrometheusRegistry registry) {
.labelNames("state")
.callback(
callback -> {
Map<String, Integer> threadStateCounts = getThreadStateCountMap(threadBean);
Map<String, Integer> threadStateCounts = getThreadStateCountMapFromThreadGroup();
for (Map.Entry<String, Integer> entry : threadStateCounts.entrySet()) {
callback.call(entry.getValue(), entry.getKey());
}
Expand All @@ -138,39 +138,45 @@ private void register(PrometheusRegistry registry) {
}
}

private Map<String, Integer> getThreadStateCountMap(ThreadMXBean threadBean) {
long[] threadIds = threadBean.getAllThreadIds();

// Code to remove any thread id values <= 0
int writePos = 0;
for (int i = 0; i < threadIds.length; i++) {
if (threadIds[i] > 0) {
threadIds[writePos++] = threadIds[i];
private Map<String, Integer> getThreadStateCountMapFromThreadGroup() {
int threadsNew = 0;
int threadsRunnable = 0;
int threadsBlocked = 0;
int threadsWaiting = 0;
int threadsTimedWaiting = 0;
int threadsTerminated = 0;
int threadsUnknown = 0;
ThreadGroup threadGroup = Thread.currentThread().getThreadGroup();
Thread[] threads = new Thread[threadGroup.activeCount()];
threadGroup.enumerate(threads);
for (Thread thread : threads) {
if (thread == null) {
// race protection
continue;
}
switch (thread.getState()) {
case NEW: threadsNew++; break;
case RUNNABLE: threadsRunnable++; break;
case BLOCKED: threadsBlocked++; break;
case WAITING: threadsWaiting++; break;
case TIMED_WAITING: threadsTimedWaiting++; break;
case TERMINATED: threadsTerminated++; break;
default:
threadsUnknown++;
}
}

final int numberOfInvalidThreadIds = threadIds.length - writePos;
threadIds = Arrays.copyOf(threadIds, writePos);

// Get thread information without computing any stack traces
ThreadInfo[] allThreads = threadBean.getThreadInfo(threadIds, 0);

// Initialize the map with all thread states
Map<String, Integer> threadCounts = new HashMap<>();
for (Thread.State state : Thread.State.values()) {
threadCounts.put(state.name(), 0);
}

// Collect the actual thread counts
for (ThreadInfo curThread : allThreads) {
if (curThread != null) {
Thread.State threadState = curThread.getThreadState();
threadCounts.put(threadState.name(), threadCounts.get(threadState.name()) + 1);
}
}

threadCounts.put(Thread.State.NEW.name(), threadsNew);
threadCounts.put(Thread.State.RUNNABLE.name(), threadsRunnable);
threadCounts.put(Thread.State.BLOCKED.name(), threadsBlocked);
threadCounts.put(Thread.State.WAITING.name(), threadsWaiting);
threadCounts.put(Thread.State.TIMED_WAITING.name(), threadsTimedWaiting);
threadCounts.put(Thread.State.TERMINATED.name(), threadsTerminated);
// Add the thread count for invalid thread ids
threadCounts.put(UNKNOWN, numberOfInvalidThreadIds);
threadCounts.put(UNKNOWN, threadsUnknown);

return threadCounts;
}
Expand Down
Loading