models_metric: Add IsValidLegacyLabelName. #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two new functions, `isValidLegacyLabelRune` and `IsValidLegacyLabelName`, to validate legacy label names and their runes. The validation logic is consolidated by reusing the `IsValidLabelCharacter` function. Signed-off-by: sujal shah <[email protected]>
|
This needs a DCO sign-off. You can use |
sujalshah-bit
force-pushed
the
add_IsValidLegacyLabelName_in_modal
branch
from
4010709 to
6ecc2fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes ensure consistent validation of label names across the codebase, particularly in cases where label names may contain invalid characters (e.g., colons). This addresses issues with escaping labels in aggregators like
by()andwithout().PR COMMENT prometheus/prometheus#15833 (comment)_