Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/no contract access by any #920

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

HughParry
Copy link
Contributor

No description provided.

Copy link

Pull Request Report

Hey there! I've analyzed the changes in the pull request and here's the report for you:

Changes

  1. In .vscode/settings.json:

    • Added "editor.codeActionsOnSave" with "source.fixAll.eslint": "explicit".
  2. In dev/scripts/src/contract/deploy/dapp.ts:

    • Imported get from @prosopo/util.
    • Added import { get } from '@prosopo/util'.
    • Modified the return statement in the run function to use get and assign the result to contractAddress.
  3. In dev/scripts/src/contract/deploy/protocol.ts:

    • Imported get from @prosopo/util.
    • Added import { get } from '@prosopo/util'.
    • Modified the return statement in the run function to use get and assign the result to contractAddress.
  4. In packages/contract/src/contract/deploy.ts:

    • Removed the type annotation : any from the filter callback function.

Suggestions

  • Consider providing more descriptive variable and function names to improve code readability.
  • Use consistent formatting and indentation throughout the codebase.
  • Add comments to explain complex logic or provide context where necessary.

Bugs

  • No bugs found.

Improvements

  • No improvements found.

Rating

I would rate the code a 7 out of 10. The code is generally readable and performs well. However, there are some areas where readability could be improved, such as using more descriptive variable names and adding comments for clarity. Overall, the code seems to be secure and free from major bugs.

That's it for the report! Let me know if you need any further assistance.

@forgetso forgetso merged commit 91dfad5 into main Dec 20, 2023
6 checks passed
@forgetso forgetso deleted the feature/no-contract-access-by-any branch December 20, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants