Add dapp to verify call

[forgetso]

No description provided.

[pr-explainer-bot]

Pull Request Report

Hey there! I've analyzed the changes made in the pull request and here's a report for you:

Changes

1. Added testDapp variable in prosopoRouter function in api.ts file.
2. Modified the condition in prosopoRouter function in api.ts file to include parsed.dapp check.
3. Added dapp parameter in verifyDappUser function in ProviderApi.ts file.
4. Modified the payload object in verifyDappUser function in ProviderApi.ts file to include dapp property.
5. Added getDappAccount() function call in Manager.ts file.
6. Modified the arguments in verifyDappUser function call in Manager.ts file to include getDappAccount() result.
7. Modified the arguments in verifyDappUser function call in server.ts file to include dapp parameter.
8. Added [ApiParams.dapp]: string() property in VerifySolutionBody object in api.ts file.

Suggestions to Improve Code

1. It would be helpful to add comments explaining the purpose of each function and block of code.
2. Consider using more descriptive variable and function names to improve code readability.
3. Avoid using magic numbers or hard-coded values. Instead, use constants or variables to make the code more maintainable.

Bugs

No bugs found.

Improvements

1. In the api.ts file, the testDapp variable could be declared as a constant to indicate that its value should not be modified.

   const testDapp = '5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM';

2. In the ProviderApi.ts file, the payload object in the verifyDappUser function could be simplified using object shorthand notation.

   const payload = {
       dapp,
       user: userAccount,
       commitmentId,
       maxVerifiedTime
   };

Rating

I would rate the code changes a 7 out of 10. The code is generally readable and the changes seem to improve the functionality. However, there is room for improvement in terms of code organization and documentation. Additionally, it would be beneficial to conduct thorough testing to ensure the changes do not introduce any unforeseen issues.

That's it for the report! Let me know if you need any further assistance. Happy coding!