Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove script that is executed on import #961

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Remove script that is executed on import #961

merged 4 commits into from
Jan 11, 2024

Conversation

forgetso
Copy link
Member

No description provided.

Copy link

Pull Request Report

Hey there! Here's a report on the changes made in this pull request. Let's dive in!

Changes

  1. Removed the start script from the package.json file in packages/cli.
  2. Removed the import of isMain from @prosopo/util in packages/cli/src/start.ts.

Suggestions

  • It seems like the start script was removed. Is there any specific reason for this? If not, it might be worth considering whether it should be kept or not.

Bugs

  • No bugs found.

Improvements

  • In the packages/cli/src/start.ts file, the import of isMain from @prosopo/util was removed. This might be a potential improvement, as it could simplify the code and remove any unnecessary dependencies.

Rating

I would rate the code a 7 out of 10. The code is generally readable and performs well. However, there are a few areas that could be improved for better readability and maintainability.

That's it for the report! Let me know if you need any further assistance. Keep up the good work! 👍

@forgetso forgetso enabled auto-merge (squash) January 11, 2024 21:05
@forgetso forgetso disabled auto-merge January 11, 2024 21:24
@forgetso forgetso merged commit 2bbf2d4 into main Jan 11, 2024
11 checks passed
@forgetso forgetso deleted the remove-cli-start branch January 11, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant